Add case for Numeric values. Redo example to work without external UDF - #174
Merged
Merged
Conversation
The case for Numeric values was missing. It can use different logic. Added some more secionts to make it more readable Changed logic for the example to use ClickHouse internal functions, so it can work on cloud installations as well
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Fixed typo and two following howevers
Contributor
|
LGTM, |
Contributor
Author
|
Good to know Dima, that would make a few things easier in the future definitelly :) Thx guys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case for Numeric values was missing. It can use different logic.
Added some more sections to make it more readable
Changed logic for the example to use ClickHouse internal functions, so it can work on cloud installations as well
I have read the CLA Document and I hereby sign the CLA