Repository navigation
Commit a2fa789
fix(rewards): resolve the reward manager from chain state, not the config secret (#1015)
## The bug
Launchpad reward-code creation derived `rewards_manager_pubkey` from the
currently configured launchpad deterministic secret:
```go
rmKey := utils.DeriveRewardManagerKeypair(cfg.LaunchpadDeterministicSecret, mintPubKey)
rewardsManagerPubkey := base58.Encode(rmKey.Public().(ed25519.PublicKey))
```
The Solana reward manager account is created **once**, at coin launch,
using whatever secret was live at the time — and it can never move. So
if that secret is later rotated, an already-launched mint starts
deriving a reward manager that has no Solana account.
The pool-creation branch then turns that into durable bad state. Its
comment says *"first reward against this mint? create the pool"*, but
the condition it actually tests is *"no pool exists for this **derived**
reward manager"*. Those mean the same thing only while the secret never
changes. After a rotation an established mint looks brand-new, and the
code quietly creates a parallel pool bound to a reward manager that
doesn't exist on chain.
Rewards written to that pool are not lost — redemption resolves the
reward manager by mint, independently — but core then records a reward
manager that doesn't correspond to the mint's actual Solana account.
## The fix
Resolve it from `sol_reward_manager_inits`, which the Solana indexer
writes from observed `InitRewardManager` instructions. That's ground
truth, and it's unaffected by the secret rotating. It's also the source
[`v1_coins_post_redeem.go`](api/v1_coins_post_redeem.go) already reads —
which is why redemption was unaffected while creation wasn't.
Creating a pool still needs the reward manager **private** key for
`rm_owner_signature`, and only derivation produces that. So the creation
path derives the keypair and checks its public half against the reward
manager Solana actually has. A mismatch is precisely the rotated-mint
case, and it now fails loudly instead of creating a pool nothing can
redeem against.
In practice that check rarely fires, which is the point:
- **established mint** — resolving the real reward manager finds the
existing pool, so the creation branch is never entered
- **mint launched under the current secret** — derived equals real,
creation proceeds as before
- **rotated mint with no pool** — the one genuinely broken case, and the
only one that errors
Both call sites (the HTTP handler and the bulk CLI) duplicated this
logic; they now share `launchpad.PrepareRewardPool` so they can't drift.
## Tests
`launchpad/reward_pool_test.go` covers:
- a mint launched under an earlier secret reuses its real pool and
**creates nothing**
- a rotated mint with no existing pool fails with
`ErrRewardManagerMismatch` and creates nothing
- a mint with no indexed reward manager fails with
`ErrRewardManagerNotIndexed` without touching cometbft
- a mint launched under the current secret still creates its pool
Verified **red against the previous behavior**: reverting to
derive-then-create fails three of these, including with `an established
mint must never look brand-new; creating a pool here is the phantom-pool
bug`.
## Notes for review
- Reads via `app.pool` rather than `app.writePool` — the latter is nil
when `WriteDbUrl` is unset, and this is the same table and pool the
redeem path already reads.
- No backfill. Rewards already bound to a derived reward manager are
untouched; this only stops new ones.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent e3d1ecc commit a2fa789
4 files changed
Lines changed: 408 additions & 87 deletions
File tree
- api
- cmd/create_reward_codes
- launchpad
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
234 | 233 | | |
235 | 234 | | |
236 | 235 | | |
237 | | - | |
| 236 | + | |
238 | 237 | | |
239 | 238 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
247 | 247 | | |
248 | | - | |
249 | | - | |
250 | 248 | | |
251 | 249 | | |
252 | 250 | | |
| |||
283 | 281 | | |
284 | 282 | | |
285 | 283 | | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | 284 | | |
294 | 285 | | |
295 | 286 | | |
| |||
299 | 290 | | |
300 | 291 | | |
301 | 292 | | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
328 | 309 | | |
329 | 310 | | |
330 | 311 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
275 | 274 | | |
276 | 275 | | |
277 | 276 | | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
287 | 281 | | |
288 | 282 | | |
289 | 283 | | |
| |||
323 | 317 | | |
324 | 318 | | |
325 | 319 | | |
326 | | - | |
| 320 | + | |
327 | 321 | | |
328 | 322 | | |
329 | 323 | | |
| |||
334 | 328 | | |
335 | 329 | | |
336 | 330 | | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
344 | 336 | | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
360 | | - | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
368 | 349 | | |
369 | 350 | | |
370 | 351 | | |
| |||
413 | 394 | | |
414 | 395 | | |
415 | 396 | | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
416 | 403 | | |
417 | 404 | | |
418 | 405 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
0 commit comments