changed hitbox visualization to only send the hrp's cframe instead of every hitbox's position to save some bandwidth

Author: Dyscarn

DysymmetricalExamplePlace.rbxl

@@ -22,8 +22,6 @@ function PlayerHurtboxCreator:Init()
 end
 
 function PlayerHurtboxCreator.CreateHurtboxesForPlayer(Player: Player, Character: Model)
-    local ManagedHurtboxes = {}
-
     local HRP = Utils.Character.GetRootPart(Character)
     local TargetCFrame = CFrame.new(HRP.CFrame.Position)
 
@@ -69,19 +67,16 @@ function PlayerHurtboxCreator.CreateHurtboxesForPlayer(Player: Player, Character
         Weld.Parent = HRP
 
         --parent it NOW instead of BEFORE so that the client can properly get the ID attribute
-        HitboxClone.Parent = Character.Hitboxes
-
-        --add it to the table for later hitbox display
-        ManagedHurtboxes[ID] = HitboxClone
+        HitboxClone.Parent = Character.Hurtboxes
     end
 
     --setup hitbox display on client
-    PlayerHurtboxCreator._SetupHurtboxViewConnections(Player, Character, ManagedHurtboxes)
+    PlayerHurtboxCreator._SetupHurtboxViewConnections(Player, Character)
 end
 
 local Framerate = 1/15
 --- Sets up all available hitboxes for the passed character.
-function PlayerHurtboxCreator._SetupHurtboxViewConnections(Player: Player, Character: Model, ManagedHitboxes: {[number]: BasePart})
+function PlayerHurtboxCreator._SetupHurtboxViewConnections(Player: Player, Character: Model)
     local JanitorInstance = Janitor.new()
     JanitorInstance:LinkToInstance(Character)
 
@@ -112,59 +107,9 @@ function PlayerHurtboxCreator._SetupHurtboxViewConnections(Player: Player, Chara
 
         LastPosition = CurrentPosition
 
-        --get every single hitbox that still exists from the managed hitboxes JUST IN FUCKING CASE.
-        local AliveHitboxes = {}
-        local Count = 0
-        for ID: number, Hitbox: BasePart in ManagedHitboxes do
-            if not (Hitbox and Hitbox.Parent) then
-                continue
-            end
-
-            Count += 1
-            AliveHitboxes[ID] = Hitbox
-        end
-
-        --if there are no available hitboxes to update, halt
-        if Count <= 0 then
-            return
-        end
-
-        --let me break this down
-        -- * header for the hitbox count (1 byte, so you can add up to 255 hitboxes)
-        -- * multiplying the amount of hitboxes by 13
-        --   * 1 byte for the ID
-        --   * 12 bytes for XYZ
-        --cool size done!!1!
-        local BufferSize = 1 + (Count * 13)
-
-        --we make the buffer
-        local Buffer = buffer.create(BufferSize)
-        --skipping the count byte because that's set by itself in an obvious manner below
-        local Offset = 1
-
-        --write count as the header
-        buffer.writeu8(Buffer, 0, Count)
-
-        --iterate over every alive hitbox to add it to the buffer
-        for ID: number, Hitbox: BasePart in AliveHitboxes do
-            --write its id as its header
-            buffer.writeu8(Buffer, Offset, ID :: any)
-            --move forward 1 byte
-            Offset += 1
-
-            --iterate over every axis from its position
-            local Position = Hitbox.CFrame.Position
-            for _, Axis in {"X", "Y", "Z"} do
-                --write it as a 32 bit float, which should be more than enough (4 bytes, up to 7 decimals)
-                buffer.writef32(Buffer, Offset, Position[Axis])
-
-                --move forward 4 bytes
-                Offset += 4
-            end
-        end
-
-        --send it to the client to update
-        Network:FireClientConnection(Player, "UpdHurtboxPos", "UREMOTE_EVENT", Buffer)
+        --sending the root's cframe directly to update the hurtboxes's cframe on the client
+        --i can send the cframe because it'll still be optimized and buffered by the networking module anyways
+        Network:FireClientConnection(Player, "UpdHurtboxPos", "UREMOTE_EVENT", Root.CFrame)
     end))
 end
 

src/ServerScriptService/Managers/PlayerManager/CharacterManager/PlayerHurtboxCreator/init.luau

@@ -7,6 +7,10 @@ local SlowOnFall = {}
 
 function SlowOnFall:Init()
     local Character = Players.LocalPlayer.Character
+    if Character:GetAttribute("Role") == "Killer" then
+        return
+    end
+    
     local Humanoid = Character:FindFirstChildWhichIsA("Humanoid")
     local Root = Utils.Character.GetRootPart(Character)
 

src/StarterCharacterScripts/PlayerAttributeManagers/SpeedManager/SlowOnFall.luau

@@ -13,7 +13,7 @@ return {
 
         --necessary tables
         local GhostHurtboxes: {[number]: BasePart} = {}
-        local TargetPositions: {[number]: Vector3} = {}
+        local TargetCFrame: CFrame = Utils.Character.GetRootPart(Character).CFrame
 
         --creating the janitor by conveniently using `Utils.Instance.ObserveChildren()`, which is bound to HurtboxFolder
         local JanitorInstance: Types.Janitor = Utils.Instance.ObserveChildren(HurtboxFolder, function(Child: Instance)
@@ -28,9 +28,6 @@ return {
                 return
             end
 
-            --add its CURRENT position to the table just in case
-            TargetPositions[ID] = Child.CFrame.Position
-
             --create its dupe with its supposed transparency
             local Ghost = Child:Clone()
             Ghost.Parent = HurtboxFolder
@@ -59,46 +56,18 @@ return {
                 GhostHurtboxes[ID]:Destroy()
             end
             GhostHurtboxes[ID] = nil
-            TargetPositions[ID] = nil
         end))
 
         --use the same janitor again to add the network connection
-        JanitorInstance:Add(Network:SetConnection("UpdHurtboxPos", "UREMOTE_EVENT", function(Buffer: buffer)
-            --start from 1 to skip the buffer's counter header at first
-            local Offset = 1
-	
-            local Count = buffer.readu8(Buffer, 0)
-            
-            --iterate over the amount of hurtboxes
-            for _ = 1, Count do
-                --get the id and increase the offset
-                local ID = buffer.readu8(Buffer, Offset)
-                Offset += 1
-                
-                --read every axis and write it to a table for creating the vector
-                local AxisTable: {[string]: number} = {}
-                for _, Axis in {"X", "Y", "Z"} do
-                    AxisTable[Axis] = buffer.readf32(Buffer, Offset)
-                    Offset += 4
-                end
-                
-                --set the new vector with the set values to the set ID
-                TargetPositions[ID] = Vector3.new(AxisTable.X, AxisTable.Y, AxisTable.Z)
-            end
+        JanitorInstance:Add(Network:SetConnection("UpdHurtboxPos", "UREMOTE_EVENT", function(_TargetCFrame: CFrame)
+            TargetCFrame = _TargetCFrame
         end))
 
         --use the same janitor yet again to add the render loop
         JanitorInstance:Add(RunService.PreRender:Connect(function(delta: number)
-            --iterate over every available position in this frame
-            for ID: number, targetPosition: Vector3 in TargetPositions do
-                --if a ghost for this ID doesn't exist, move on to the next one
-                local Ghost = GhostHurtboxes[ID]
-                if not Ghost then
-                    continue
-                end
-
-                --lerp the ghost's position to its supposed target position
-                Ghost.CFrame = CFrame.new(Ghost.Position:Lerp(targetPosition, delta * 20))
+            for _, Ghost in GhostHurtboxes do
+                Ghost.CFrame = Ghost.CFrame:Lerp(TargetCFrame, delta * 20)
+                -- Ghost.CFrame = TargetCFrame
             end
         end))
     end,