Apply the last review's wording and test suggestions

The changelog says it is the file axis's attributes that are written, the
Flush docstring no longer credits C# for deferring a bad value, and the bad
file axis test checks that the file is closed through Flush, not a field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: ryan-kipawa

CHANGELOG.md

@@ -13,13 +13,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   assigning an item's `Name` or `Quantity`, or changing an attribute of its
   `SpatialAxis` (such as `X0`), writes the change to the file. For a static
   item, `WriteStaticItemData` writes it. On a dfs1, dfs2 or dfs3 file,
-  changing `SpatialAxis` updates every dynamic item on `Flush` or `Close`,
-  and the static items with the same type of axis on `Close`. As in the C#
-  library, a new name is truncated or padded to the length of the old one,
-  and changing `Quantity.Item` or `Quantity.Unit` in place is not written.
-  `SpatialAxis` of a dfs1, dfs2 or dfs3 file is now a copy of the first
-  item's axis, as in the C# library, so changing it in a file opened for
-  reading no longer changes that item's axis
+  changing an attribute of the file's `SpatialAxis` updates every dynamic
+  item on `Flush` or `Close`, and the static items with the same type of
+  axis on `Close`. As in the C# library, a new name is truncated or padded
+  to the length of the old one, and changing `Quantity.Item` or
+  `Quantity.Unit` in place is not written. `SpatialAxis` of a dfs1, dfs2 or
+  dfs3 file is now a copy of the first item's axis, as in the C# library, so
+  changing it in a file opened for reading no longer changes that item's
+  axis
   ([#38](https://github.com/DHI/mikecore-python/issues/38)).
 - `DfsuFile.Flush()` flushes the file instead of raising `TypeError`, and
   `DfsFileFactory.DfsuFileOpenAppend` no longer requires `parameters`, like the

mikecore/Dfs123File.py

@@ -64,8 +64,8 @@ def Flush(self):
         dynamic items here, and to the static items only on Close: writing a
         static item moves the file pointer, so a time step appended after
         Flush would overwrite another. The C# library writes both on Flush.
-        As in the C# library, a value the file axis cannot hold is only
-        rejected here or on Close, not when it is set.
+        A value the file axis cannot hold is only rejected here or on Close,
+        not when it is set.
         The whole file axis is written to each item, replacing changes made
         to an item's own axis, as in the C# library.
         """

tests/test_dfs_edit.py

@@ -781,8 +781,8 @@ def test_file_axis_reaches_an_item_whose_axis_was_replaced(fileAxisCase, replace
 
 def test_bad_file_axis_value_is_rejected_on_flush_and_close(fileAxisCase):
     """
-    As in the C# library, a value the file axis cannot hold is accepted when
-    set and rejected on Flush and Close. The file is still closed, unchanged.
+    A value the file axis cannot hold is accepted when set and rejected on
+    Flush and Close. The file is still closed, unchanged.
     """
     case = fileAxisCase
     original = readBytes(case.filename)
@@ -794,5 +794,6 @@ def test_bad_file_axis_value_is_rejected_on_flush_and_close(fileAxisCase):
     with pytest.raises(AttributeError):
         file.Close()
 
-    assert file.filePointer.value is None
+    with pytest.raises(OSError):
+        file.Flush()
     assert original == readBytes(case.filename)