Skip to content

Commit 5c2550b

Browse files
test(agents): score the mapper leak as a correctness lens
The full-skill run was losing the gate to an uninstructed baseline. Evaluate firstSpanWritten the same way as the JS correctness cases.
1 parent d0e30a0 commit 5c2550b

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

‎.llm-validation/suites/dd-apm-sdk-review.yaml‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -326,14 +326,12 @@ cases:
326326

327327
- id: java-correctness-mapper-state-leak
328328
files:
329-
- .agents/skills/dd-apm-sdk-review/SKILL.md
330329
- .agents/skills/dd-apm-sdk-review/reviewers/_common.md
331330
- .agents/skills/dd-apm-sdk-review/reviewers/correctness.md
332-
- .agents/skills/dd-apm-sdk-review/reviewers/report-template.md
333331
input: |
334-
Run dd-apm-sdk-review on the following change. There is no git repository to
335-
inspect — this diff is the entire change set; do not attempt any git commands, go
336-
straight to running the reviewers on the pasted content below.
332+
Apply this repo's correctness-review criteria (reviewers/correctness.md and _common.md)
333+
to the following change. No git checkout available — this snippet is the entire
334+
change to review.
337335
338336
```diff
339337
diff --git a/dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapperV0_4.java b/dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapperV0_4.java
@@ -363,7 +361,6 @@ cases:
363361
- "Flags that `firstSpanWritten` is an instance field that is only ever set to `true` and is never cleared between payloads."
364362
- "Explains the concrete consequence given mapper reuse across the writer's lifetime: after the first payload, later payloads never write process/propagation tags (`dd-p-*`) — silent cross-payload data loss."
365363
- "Recommends clearing `firstSpanWritten` in `reset()` (the payload-flush hook), not at the start of every `map()` — a per-map reset would write the tags on every chunk of the same payload."
366-
- "States an explicit verdict line and the matching gate line: `DO NOT PUSH` on BLOCK, `WAITING ON HUMAN` on APPROVE_WITH_COMMENTS, or `READY TO PUSH` on APPROVE."
367364
bad_signals:
368365
- "Notes the flag exists but misses that nothing re-initializes it per payload."
369366
- "Suggests resetting the field at the start of every `map()` (or only \"make it volatile\" / \"add logging\")."

0 commit comments

Comments
 (0)