Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Abstracting some code that is copy pasted a few times. #885

Description

@NickyDaB

Summary:

  const int32_t TS_BUFF_SIZE(80);
  const int32_t TS_USEC_SIZE(120);

is referenced a few times in the code.

At least once in these files:

Instead of defining the const vars in each file. I suggest we make a daemon def include file. Then include that and use those consts.

Advantage:

  • If we have to change the value in the future, then we change it in one spot and all values are updated. VS leaving it this way. If we need to update it, then we might accidentally miss one value.

Is your feature request related to a problem? Please describe.

Not really a problem. But the issue is described above in the advantage section.

Describe alternatives you've considered

We could also even make a "construct timestamp function" which could even be more robust.

Issue Source:

Other Notes:

  • This is a good first issue and simple issue that might be included in a 24 or 48 hours sprint.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions