Release v0.0.1 - #29
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the repository for the v0.0.1 release by aligning licensing across Rust/Python/docs, introducing a publishable sandd-protocol crate, and adding release/publish workflow helpers.
Changes:
- Switched project licensing from MIT to Apache-2.0 across manifests, docs, README, and LICENSE.
- Promoted
sandd-protocolto a publishable crate at v0.0.1 and updatedsanddto depend on it with an explicit version for crates.io publishing. - Enhanced release automation via Makefile publish targets and maturin packaging excludes.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/Cargo.toml | Updates crate license metadata (but currently leaves server crate version at 0.0.0). |
| sandd/Cargo.toml | Sets Apache-2.0 license and pins sandd-protocol dependency with version for publishability. |
| protocol/Cargo.toml | Bumps protocol crate to 0.0.1 and adds crates.io metadata (license/description/links). |
| Cargo.lock | Reflects the protocol crate version bump to 0.0.1. |
| pyproject.toml | Updates Python package license and adjusts maturin exclude patterns to avoid duplicate wheel entries. |
| Makefile | Adds publish ordering/idempotence logic and a dry-run helper for crate publishing. |
| README.md | Updates license badge and license section to Apache-2.0. |
| LICENSE | Replaces MIT text with Apache License 2.0 text. |
| docs/DEVELOP.md | Updates dependency licensing compatibility guidance to Apache-2.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+5
| version = "0.0.0" | ||
| edition = "2021" | ||
| license = "MIT" | ||
| license = "Apache-2.0" |
Comment on lines
140
to
154
| # Publish the daemon to crates.io. sandd-protocol must go first: cargo strips the | ||
| # `path` dependency on publish and resolves it from the registry instead, so the | ||
| # protocol crate has to already be there. `--skip-existing`-style reruns aren't | ||
| # supported, so a version already published is treated as success. | ||
| publish-crate: | ||
| @PROTO_VERSION=$$(grep -m1 '^version' protocol/Cargo.toml | cut -d'"' -f2); \ | ||
| if curl -sf "https://index.crates.io/sa/nd/sandd-protocol" 2>/dev/null \ | ||
| | grep -q "\"vers\":\"$$PROTO_VERSION\""; then \ | ||
| echo "sandd-protocol $$PROTO_VERSION already on crates.io; skipping."; \ | ||
| else \ | ||
| echo "Publishing sandd-protocol $$PROTO_VERSION to crates.io..."; \ | ||
| cargo publish --package sandd-protocol; \ | ||
| fi | ||
| @echo "Publishing sandd daemon to crates.io..." | ||
| cargo publish --package sandd |
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
approved these changes
Aug 1, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?