In the EPM in Integrate.cpp think the soot kernel is incorrectly being created as a "liquid" type kernel instead of a "soot" type kernel. See here:
|
const AIM::Coagulation Kernel( "liquid", SO4_rJ, SO4_vJ, RHO_SULF, temperature_K, simVars_.pressure_Pa ); |
|
const AIM::Coagulation Kernel_SO4_Soot( "liquid", SO4_rJ, RHO_SULF, EI_.getSootRad(), RHO_SOOT, temperature_K, simVars_.pressure_Pa ); |
Looking at the constructor of Coagulation both lead to the same result to the same object (no effect on scientific results), however this is just plain misleading and also duplicates code as there are two implementations of as far as I can tell the exact same operations in Coagulation::Coagulation for the liquid and soot case.
In the EPM in
Integrate.cppthink the soot kernel is incorrectly being created as a "liquid" type kernel instead of a "soot" type kernel. See here:APCEMM/Code.v05-00/src/EPM/Models/Original/Integrate.cpp
Lines 145 to 146 in adf714b
Looking at the constructor of
Coagulationboth lead to the same result to the same object (no effect on scientific results), however this is just plain misleading and also duplicates code as there are two implementations of as far as I can tell the exact same operations inCoagulation::Coagulationfor the liquid and soot case.