Skip to content

Commit 7430670

Browse files
test: verify replacement documents after Firefox reload errors (#160)
* test: verify replacement documents after Firefox reload errors * test: retain the original interrupted reload error
1 parent 105f52f commit 7430670

2 files changed

Lines changed: 23 additions & 7 deletions

File tree

‎scripts/browser-reload.mjs‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,25 @@ export async function reloadDocument(page, { timeout = 30000 } = {}) {
1515
// Next's development socket may initiate a second reload while the first
1616
// document request is pending. Observe the browser's resulting document.
1717
let directResponse
18+
let interruption
1819
try {
1920
directResponse = await page.reload({ waitUntil: 'load', timeout: remaining() })
2021
} catch (error) {
21-
if (!/ERR_ABORTED|NS_BINDING_ABORTED|interrupted by another navigation|Frame load interrupted/.test(String(error))) throw error
22+
if (!/ERR_ABORTED|NS_BINDING_ABORTED|NS_ERROR_FAILURE|interrupted by another navigation|Frame load interrupted/.test(String(error))) throw error
23+
interruption = error
2224
}
2325
// The reload command returns its document response even if WebKit omits
2426
// the corresponding page response event. Interrupted reloads use the
2527
// resulting document observed above, without issuing another navigation.
28+
// Firefox can report NS_ERROR_FAILURE for the interrupted command. The
29+
// new time origin, matching URL, and successful response still must pass.
2630
response ||= directResponse
27-
await page.waitForFunction(previous => performance.timeOrigin !== previous, previous, { timeout: remaining() })
31+
try {
32+
await page.waitForFunction(previous => performance.timeOrigin !== previous, previous, { timeout: remaining() })
33+
} catch (error) {
34+
if (interruption && error.name === 'TimeoutError') throw interruption
35+
throw error
36+
}
2837
await page.waitForLoadState('load', { timeout: remaining() })
2938
assert.equal(page.url(), url, 'Reload must preserve the current URL')
3039
assert.ok(response && response.status() < 400, `Reload must receive a successful document response, received ${response?.status()}`)

‎scripts/test-browser-reload.mjs‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,23 @@ try {
2828
for (const engine of engines) {
2929
const browser = await types[engine].launch({ headless: true })
3030
try {
31-
for (const mode of ['normal', 'interrupted', 'canceled', 'server-error', 'redirected', 'missing-response-event', 'server-error-missing-response-event']) {
31+
for (const mode of ['normal', 'interrupted', 'canceled', 'server-error', 'redirected', 'missing-response-event', 'server-error-missing-response-event', 'firefox-replaced-response', 'firefox-no-replacement', 'server-error-firefox-replaced-response']) {
3232
const page = await browser.newPage()
3333
page.setDefaultTimeout(1500)
3434
await page.goto(`http://127.0.0.1:${server.address().port}/?engine=${engine}&mode=${mode}`)
3535
const previous = await page.evaluate(() => performance.timeOrigin)
36-
// Reproduce a missing Playwright response event while the real browser
37-
// still loads a document. URL, time origin and HTTP status remain real.
38-
const reloadPage = mode.includes('missing-response-event') ? new Proxy(page, {
36+
// Reproduce missing response events and rejected reload commands
37+
// while the browser still supplies real document and HTTP evidence.
38+
const reloadPage = mode.includes('missing-response-event') || mode.includes('firefox-') ? new Proxy(page, {
3939
get(target, key) {
4040
if (key === 'on' || key === 'off') return (event, listener) => {
41-
if (event !== 'response') target[key](event, listener)
41+
if (!mode.includes('missing-response-event') || event !== 'response') target[key](event, listener)
4242
return target
4343
}
44+
if (key === 'reload' && mode.includes('firefox-')) return async options => {
45+
if (!mode.includes('no-replacement')) await target.reload({ ...options, waitUntil: 'commit' })
46+
throw new Error('page.reload: NS_ERROR_FAILURE')
47+
}
4448
const value = Reflect.get(target, key)
4549
return typeof value === 'function' ? value.bind(target) : value
4650
},
@@ -52,6 +56,9 @@ try {
5256
await assert.rejects(reloadDocument(reloadPage, { timeout: 1500 }))
5357
assert.equal(dismissed, true)
5458
assert.equal(await page.evaluate(() => performance.timeOrigin), previous)
59+
} else if (mode === 'firefox-no-replacement') {
60+
await assert.rejects(reloadDocument(reloadPage, { timeout: 1500 }), /page\.reload: NS_ERROR_FAILURE/)
61+
assert.equal(await page.evaluate(() => performance.timeOrigin), previous)
5562
} else if (mode.startsWith('server-error')) await assert.rejects(reloadDocument(reloadPage), /received 500/)
5663
else if (mode === 'redirected') await assert.rejects(reloadDocument(reloadPage), /preserve the current URL/)
5764
else {

0 commit comments

Comments
 (0)