when creating a DB the script should refuse to create if the schemas already exist.

[DaanHoogland]

The required feature described as a wish

As a Operator I would like to , be able to run the create DB scripts without the possibility of having my production DB destroyed when I try to configure a second MS to use the same DB.
The script, cloudstack-setup-databases, should not run if a DB schema is found and not explicitly deleted/dropped beforehand.

[nvazquez]

Hi @DaanHoogland do you mean to not run if cloud and/or cloud_usage databases are present?

I have been doing some checks and we can have some conflicts with an existing optional parameter to create schemas only:

  -s, --schema-only     Creates the db schema without having to pass root
                        credentials - Please note: The databases (cloud,
                        cloud_usage) and user (cloud) has to be configured
                        manually prior to running this script when using this
                        flag.

In this case if admins pass the --schema-only option, CloudStack would expect the cloud (and cloud_usage) databases to be already created.

[DaanHoogland]

I would prefer it to have a —allow-recreate flag and not drop anything if it is there but abort instead. @adietrich-ussignal , any opinion?

[adietrich-ussignal]

@DaanHoogland Yeah I think that is the right call, because the schema flag is really independent of what we are trying to achieve with preventing a potential override of the DB.

@nvazquez I would think there would need to be sufficient checks for more than the presence of cloud and cloud_usage to determine if the database already has a schema applied to achieve the ask.

[nvazquez]

Thanks @adietrich-ussignal I agree - was not clear to me from the issue description. We'll work with @DaanHoogland on the checks definition for the script.

[nvazquez]

@adietrich-ussignal I'll be opening a PR with a new parameter to explicitly allow the DB recreation, otherwise the default behavior should be non-destructive. What do you think?

  -s, --schema-only     Creates the db schema without having to pass root
                        credentials - Please note: The databases (cloud,
                        cloud_usage) and user (cloud) has to be configured
                        manually prior to running this script when using this
                        flag.
  -x, --force-recreation
                        Force recreation of the existing DB schemas. This
                        option is disabled by default. Please note: The
                        databases (cloud, cloud_usage) and its tables data
                        will be lost and recreated.

[adietrich-ussignal]

@nvazquez That makes sense to me, but maybe call it 'force-recreate'? Does it also make sense to remove the single letter flag given this is a more special option? I'm not sure the -x option maps as well to the command.

[DaanHoogland]

@nvazquez That makes sense to me, but maybe call it 'force-recreate'? Does it also make sense to remove the single letter flag given this is a more special option? I'm not sure the -x option maps as well to the command.

is -f already taken?

[nvazquez]

Thanks @adietrich-ussignal @DaanHoogland I'll rename it 'force-recreate'. Yes -f and -r were already taken, will try removing the single letter and keeping the name parameter only