Skip to content

Commit 3a243fe

Browse files
Potential fix for code scanning alert no. 6: XPath injection
XPath Injection fix for: src/main/java/org/owasp/benchmark/testcode/Benchmark00207.java:74 Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 parent 5cec9ee commit 3a243fe

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

‎src/main/java/org/owasp/benchmark/testcode/Benchmark00207.java‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,17 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
7171
javax.xml.xpath.XPathFactory xpf = javax.xml.xpath.XPathFactory.newInstance();
7272
javax.xml.xpath.XPath xp = xpf.newXPath();
7373

74-
String expression = "/Employees/Employee[@emplid='" + bar + "']";
74+
String expression = "/Employees/Employee[@emplid=$emplid]";
75+
xp.setXPathVariableResolver(
76+
new javax.xml.xpath.XPathVariableResolver() {
77+
@Override
78+
public Object resolveVariable(javax.xml.namespace.QName variableName) {
79+
if ("emplid".equals(variableName.getLocalPart())) {
80+
return bar;
81+
}
82+
return null;
83+
}
84+
});
7585
String result = xp.evaluate(expression, xmlDocument);
7686

7787
response.getWriter().println("Your query results are: " + result + "<br/>");

0 commit comments

Comments
 (0)