Merge pull request #1199 from cloudinary/fix/suppress-filters-internal-queries

Suppress content filters on internal asset bookkeeping queries

Author: gabrielcld2

php/class-assets.php

@@ -601,14 +601,19 @@ private function process_parent_assets( $parent_id, $callback ) {
 			return;
 		}
 
-		$query_args     = array(
+		$query_args = array(
 			'post_type'              => self::POST_TYPE_SLUG,
 			'posts_per_page'         => 100,
 			'post_parent'            => $parent_id,
 			'post_status'            => array( 'inherit', 'draft' ),
 			'fields'                 => 'ids',
 			'update_post_meta_cache' => false,
 			'update_post_term_cache' => false,
+			// Internal bookkeeping query over our own post type: do not run
+			// third-party content filters (e.g. `the_posts`) meant for
+			// public-facing queries. The query is fully specified, so the
+			// filters VIP protects (posts_where/join/orderby) are not relied on.
+			'suppress_filters'       => true, // phpcs:ignore WordPressVIPMinimum.Performance.WPQueryParams.SuppressFilters_suppress_filters
 		);
 		$query          = new \WP_Query( $query_args );
 		$previous_total = $query->found_posts;
@@ -987,6 +992,11 @@ protected function init_asset_parents() {
 			'no_found_rows'          => true,
 			'update_post_meta_cache' => false,
 			'update_post_term_cache' => false,
+			// Internal bookkeeping query over our own post type: do not run
+			// third-party content filters (e.g. `the_posts`) meant for
+			// public-facing queries. The query is fully specified, so the
+			// filters VIP protects (posts_where/join/orderby) are not relied on.
+			'suppress_filters'       => true, // phpcs:ignore WordPressVIPMinimum.Performance.WPQueryParams.SuppressFilters_suppress_filters
 		);
 		$query               = new \WP_Query( $args );
 		$this->asset_parents = array();