Repository navigation
fix(notifications): wire the streak reminder and following email controls, drop the tag bell - #6886
Merged
Merged
Conversation
…rols, drop the tag bell The streak reminder checkbox in settings toggled notificationFlags.streak_reminder, which nothing schedules. Since the settings redesign it showed on for everyone while only people who opted in from the streak milestone modal got the push. Both surfaces now share useStreakReminder: on means a scheduled reminder that is not muted, turning it on schedules it at 20:00 on workdays and unmutes the flag, turning it off removes the schedule. The email Following switch toggled the in-app key set, so it skipped squad post emails (shown under it) and toggled read it later, which has no email. It now uses the followingEmail group, and the read it later row is gone from the email tab. The tag page bell saved the keyword follow as subscribed, but no notification type, worker or copy exists for posts in a followed tag, so it never sent anything. Remove the bell until that pipeline exists.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tsahimatsliah
added a commit
that referenced
this pull request
Oct 13, 2026
Main's new following-group test (#6886) clicked the Email tab, which the phone page reaches through ?tab= instead; it opens the tab the way the branch's other email tests do. The overlay spec reads the field's layer with optional chaining for strict mode.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Three notification controls did nothing. API side: dailydotdev/daily-api#4400.
Streak reminder ("Notify me before my streak expires")
notificationFlags.streak_reminder, which nothing schedules. The push is driven by thestreak_reminderpersonalized digest row, which only the streak milestone modal created. So the box showed on for everyone but only modal opt-ins got the push, and unchecking it never stopped it.useStreakReminderhook, used by both the settings checkbox andStreakReminderSwitch: on means a scheduled reminder that is not muted. Turning it on schedules 20:00 on workdays and unmutes the flag; turning it off removes the schedule.Email "Following" group
following), so it skipped squad post emails shown under it and toggled "Read it later", which has no email. It now uses the existing, previously unusedfollowingEmailgroup, and the "Read it later" row is gone from the email tab. No setting key renamed, so old extension builds are unaffected.Tag bell
subscribed, but no notification type, worker or copy exists for posts in a followed tag, so it never sent anything. The bell is removed from the tag page, along with its tests.Events
No new event names. The settings streak checkbox now sends the same events as the streak modal switch:
enable notification/disable notificationwith{ channel: web, category: streak_reminder }, andschedule streak reminderon enable.Experiment
No new experiments.
Preview domain
https://fix-notification-controls.preview.app.daily.dev