Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On phones,
/<username>now opens on the user's Posts, and About sits beside it as the second segment. The order is Posts · About · Replies · Upvoted, which matches the Squad page (Posts first, About second).Until now, a phone profile opened on About (highlights, profile activity and so on), and a visitor only saw what the person posted after tapping Posts. We're also moving away from the recruiting-first profile, so About no longer needs to be the landing view.
How
ProfileSegments: Posts is first and points to/<username>. About points to the new/<username>/about.pages/[userId]/index.tsx: on a phone, the Posts segment shows the header, the segments and the author feed. On the About segment it shows everything that used to be there (About me, showcase, stack, share, Highlights, experiences).pages/[userId]/about.tsx(new): re-exports the profile page and its ISRgetStaticProps/getStaticPaths. The page readsrouter.pathnameto decide which segment is open. The profile SEO defaults already point the canonical at/<username>, so nothing new gets indexed. This is a real page rather than a rewrite on purpose: anafterFilesrewrite of/:userId/aboutwould run before dynamic routes and catch paths like/squads/about.components/profile/ProfilePostsFeed.tsx(new): the author feed and its empty states, moved out ofposts.tsxso the profile page and/<username>/postsshare it.Tablet and desktop are unchanged: the whole profile still shows, with the inline Activity tabs. The server render is also unchanged (
useIsPhoneis false there), so crawlers still get the About content.Checks
tsc --noEmit(webapp) and eslint on the changed files passsharedshell tests andActivity.specpassPR opened by Smith (AI assistant) at Nimrod's request.
Preview domain
https://feat-profile-posts-first.preview.app.daily.dev