Repository navigation
Conversation
|
Codex implemented the optional connection helper, moved shared action execution into this layer and restacked the imports at Gabe’s request. Standalone checks and the complete 901-test stack passed; current-head CI and Devin review are complete. Gabe reviewed the final changes at — Codex |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4791 +/- ##
==========================================
+ Coverage 76.61% 76.82% +0.21%
==========================================
Files 1101 1107 +6
Lines 55355 55984 +629
Branches 12195 12340 +145
==========================================
+ Hits 42406 43005 +599
- Misses 11961 11990 +29
- Partials 988 989 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7b3bbf9 to
04b5495
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
04b5495 to
5261e34
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5261e34 to
f2c3b5c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f2c3b5c to
0de7ec0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0de7ec0 to
1899090
Compare
|
✅ Thank you for adding a changeset! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Why
Repeated control commands reconnect to the preview server. Let agents keep the connection ready between commands.
How
Add an optional local helper and share action preparation, uploads, downloads and execution. Ordinary control commands reuse the helper when available. The idle timeout defaults to 120 seconds.
--idle-timeouttakes seconds. Closing the connection leaves the simulator session running. Keep-alive supports macOS and Linux; ordinary commands still work on Windows. Control import (#4686) and start import (#4687) use this shared executor.Security and cleanup
The helper uses an owned, private Unix socket directory. Processes running as the same OS user share this authority. Discovery is scoped to EAS credentials, project, session, API environment and CLI installation/version. Preview credentials pass over parent-child IPC; no new credential file is written.
Callers run one at a time. A dropped reply never triggers an automatic replay. Messages, queues and waits are bounded. Close finishes the in-flight action, rejects later actions and permits bounded upload cleanup. Immediate reopen waits for the drain.
Saved-login changes, idle expiry and remote disconnect close the helper. Server-side access-token revocation is not polled. An already-dispatched action can finish during shutdown.
Test Plan
Codex ran standalone control/helper tests, a clean package build, typecheck, lint and formatting. The complete stack passed 901 simulator/help tests across 35 suites. Node 22/24, GraphQL, changeset and coverage checks pass on this head. Devin completed; its import-scope note is addressed.
Codecov patch coverage is 94.57%. Worker bootstrap/exit paths and some error branches remain uncovered; no coverage exclusions were added. Hosted EAS session testing and latency measurements remain pending.
Authorship and LLM use
Gabe chose the connection commands and timeout, then asked to share the control code with imports. Codex implemented the helper, moved the action executor into this layer and restacked the imports. Gabe reviewed the final changes at
1899090.Astra and Opus reviews led to removing redundant authentication and validation, then fixing admission and shutdown races. Devin identified the close/reopen race. Coverage reviews corrected a masked shutdown assertion and a fake-timer race. Independent rechecks were clean on the earlier combined implementation; Codex checked the reorganized layers and preserved feature tree. Those independent reviews and hosted testing were not repeated for the split.
— Codex