Skip to content

Commit b0cf97d

Browse files
committed
ref(android-nav3): Rename nav3 destination hint
Keep the hint internal for the current stack, but mark it experimental ahead of the follow-on public surface work. Also rename the key and field to match the Android hint naming pattern.
1 parent 0dc52a0 commit b0cf97d

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎sentry-android-navigation3/src/main/kotlin/io/sentry/compose/navigation3/BackStackObserver.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ internal class BackStackObserver<T : Any>(
296296
}
297297

298298
val hint = Hint()
299-
hint.set(TypeCheckHint.NAV3_DESTINATION, toEntry)
299+
hint.set(TypeCheckHint.ANDROID_NAV3_DESTINATION, toEntry)
300300
this.addBreadcrumb(breadcrumb, hint)
301301
}
302302

‎sentry-android-navigation3/src/test/kotlin/io/sentry/compose/navigation3/BackStackObserverTest.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class BackStackObserverTest {
149149
"to_arguments",
150150
mapOf("userId" to "123"),
151151
)
152-
assertThat(fixture.breadcrumbHints.last().get(TypeCheckHint.NAV3_DESTINATION))
152+
assertThat(fixture.breadcrumbHints.last().get(TypeCheckHint.ANDROID_NAV3_DESTINATION))
153153
.isSameInstanceAs(profile)
154154
}
155155

@@ -285,7 +285,7 @@ class BackStackObserverTest {
285285
assertThat(fixture.breadcrumbs).hasSize(2)
286286
assertThat(fixture.breadcrumbs.last().data["from"]).isEqualTo("/ProfileRoute")
287287
assertThat(fixture.breadcrumbs.last().data["to"]).isEqualTo("/ProfileRoute")
288-
assertThat(fixture.breadcrumbHints.last().get(TypeCheckHint.NAV3_DESTINATION))
288+
assertThat(fixture.breadcrumbHints.last().get(TypeCheckHint.ANDROID_NAV3_DESTINATION))
289289
.isSameInstanceAs(replacementProfile)
290290
assertThat(fixture.startedTransactions).hasSize(2)
291291
assertThat(fixture.startedTransactions.last().name).isEqualTo("/ProfileRoute")

‎sentry/api/sentry.api‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4730,6 +4730,7 @@ public final class io/sentry/TypeCheckHint {
47304730
public static final field ANDROID_FRAGMENT Ljava/lang/String;
47314731
public static final field ANDROID_INTENT Ljava/lang/String;
47324732
public static final field ANDROID_MOTION_EVENT Ljava/lang/String;
4733+
public static final field ANDROID_NAV3_DESTINATION Ljava/lang/String;
47334734
public static final field ANDROID_NAV_DESTINATION Ljava/lang/String;
47344735
public static final field ANDROID_NETWORK_CAPABILITIES Ljava/lang/String;
47354736
public static final field ANDROID_SENSOR_EVENT Ljava/lang/String;
@@ -4743,7 +4744,6 @@ public final class io/sentry/TypeCheckHint {
47434744
public static final field KTOR_CLIENT_RESPONSE Ljava/lang/String;
47444745
public static final field LOG4J_LOG_EVENT Ljava/lang/String;
47454746
public static final field LOGBACK_LOGGING_EVENT Ljava/lang/String;
4746-
public static final field NAV3_DESTINATION Ljava/lang/String;
47474747
public static final field OKHTTP_REQUEST Ljava/lang/String;
47484748
public static final field OKHTTP_RESPONSE Ljava/lang/String;
47494749
public static final field OPEN_FEIGN_REQUEST Ljava/lang/String;

‎sentry/src/main/java/io/sentry/TypeCheckHint.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ public final class TypeCheckHint {
5252
public static final String ANDROID_NAV_DESTINATION = "android:navigationDestination";
5353

5454
/** Used for Navigation 3 breadcrumbs. */
55-
@ApiStatus.Internal public static final String NAV3_DESTINATION = "navigation3:destination";
55+
@ApiStatus.Experimental @ApiStatus.Internal
56+
public static final String ANDROID_NAV3_DESTINATION = "android:nav3Destination";
5657

5758
/** Used for Network breadrcrumbs. */
5859
public static final String ANDROID_NETWORK_CAPABILITIES = "android:networkCapabilities";

0 commit comments

Comments
 (0)