Skip to content

Commit cfa8248

Browse files
committed
Address runningcode's comments
1 parent 15d7842 commit cfa8248

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

‎sentry-android-navigation3/src/main/kotlin/io/sentry/compose/navigation3/SentryNavEffect.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ internal fun <T : Any> SentryNavEffect(
9797
options: SentryNavOptions = SentryNavOptions(),
9898
scopes: IScopes,
9999
) {
100-
val routeResolvers = rememberUpdatedState(RouteResolvers(nameExtractor, argumentsExtractor))
100+
val routeExtractors = rememberUpdatedState(RouteExtractors(nameExtractor, argumentsExtractor))
101101

102102
val observer =
103103
remember(scopes, options) {
104104
BackStackObserver(
105105
scopes = scopes,
106106
options = options,
107-
resolvers = { routeResolvers.value },
107+
extractors = { routeExtractors.value },
108108
)
109109
}
110110

‎sentry-android-navigation3/src/test/kotlin/io/sentry/compose/navigation3/BackStackKeyTest.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.sentry.compose.navigation3
22

33
import com.google.common.truth.Truth.assertThat
4-
import kotlin.test.Test
4+
import org.junit.Test
55

66
class BackStackKeyTest {
77

‎sentry-android-navigation3/src/test/kotlin/io/sentry/compose/navigation3/SentryNavEffectTest.kt‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ import io.sentry.SentryOptions
2222
import io.sentry.SentryTracer
2323
import io.sentry.TransactionContext
2424
import io.sentry.TransactionOptions
25-
import kotlin.test.Test
26-
import kotlin.test.assertNull
2725
import org.junit.Rule
26+
import org.junit.Test
2827
import org.junit.rules.TestWatcher
2928
import org.junit.runner.Description
3029
import org.junit.runner.RunWith
@@ -529,7 +528,7 @@ class SentryNavEffectTest {
529528
assertThat(fixture.breadcrumbs.single().data["to"]).isEqualTo("/HomeRoute")
530529
assertThat(fixture.scope.transaction).isNull()
531530
assertThat(fixture.scope.screen).isNull()
532-
assertNull(fixture.scope.contexts.app?.viewNames)
531+
assertThat(fixture.scope.contexts.app?.viewNames).isNull()
533532
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
534533
}
535534

0 commit comments

Comments
 (0)