Skip to content

Added initial implementations of to<T> functions - #99

Open
jmacgowan wants to merge 12 commits into
libsemigroups:mainfrom
jmacgowan:main
Open

jmacgowan wants to merge 12 commits into
libsemigroups:mainfrom
jmacgowan:main

Conversation

@jmacgowan

Copy link
Copy Markdown
  • Added to<> function for: presentation, knuth_bendix, froidure_pin, congruence.
  • Added tests for all
  • NOTE: This PR does not extend any of the unimplemented templates that exist in libsemigroups, such as the stdstring option for presentations, however it covers all 10 FroidurePin instantiations that already existed.

@james-d-mitchell

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@aa76229). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage        ?   73.69%           
=======================================
  Files           ?       26           
  Lines           ?     1574           
  Branches        ?        0           
=======================================
  Hits            ?     1160           
  Misses          ?      414           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jswent

jswent commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Hi @jmacgowan, sorry I missed this. I will have a look at it tonight.

In the future, feel free to ping me if you want to get my attention, as I get a lot of activity on GitHub so stuff gets buried.

EDIT: Unless @james-d-mitchell would you prefer to review this?

@jswent
jswent self-requested a review September 30, 2026 16:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants