Skip to content

Commit b70aa79

Browse files
joyeecheunglegendecas
authored andcommitted
build: use v8_use_metagen in build flags
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8524366 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent f5fe81f commit b70aa79

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎tools/make-v8.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
7070
;;
7171
*) GN_COMPILER_OPTS="treat_warnings_as_errors=false use_custom_libcxx=false" ;;
7272
esac
73-
gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="$GN_COMPILER_OPTS is_component_build=false is_debug=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true v8_use_metagen_instance_types=false ${GN_RUST_ARGS} $CC_WRAPPER"
73+
gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="$GN_COMPILER_OPTS is_component_build=false is_debug=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true v8_use_metagen=false ${GN_RUST_ARGS} $CC_WRAPPER"
7474
ninja -v -C "out.gn/$BUILD_ARCH_TYPE" "${JOBS_ARG}" d8 cctest inspector-test
7575
else
7676
DEPOT_TOOLS_DIR="$(cd depot_tools && pwd)"

‎tools/v8_gypfiles/features.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@
581581
'V8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=<(v8_typed_array_max_size_in_heap)',
582582
# See deps/v8/src/objects/instance-types-gen.h and
583583
# https://github.com/nodejs/build/issues/4350
584-
'V8_USE_METAGEN_INSTANCE_TYPES=0',
584+
'V8_USE_METAGEN=0',
585585
], # defines
586586
}, # target_defaults
587587
}

0 commit comments

Comments
 (0)