Repository navigation
Support ipyvuetify 3 in MapLibre widgets - #1414
Conversation
ipyvuetify 3 wraps Vuetify 3, which renamed expansion panel and tab components and replaced boolean size and style props, so the MapLibre map failed to display. Add a small compatibility module so the widgets work with both ipyvuetify 1.x and 3.x.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Code reviewI reviewed the Vuetify 2/3 compatibility layer ( Bugs
Security
Performance
Quality
CLAUDE.md
|
|
🚀 Deployed on https://6af6158e6f943266c1b69565--opengeos.netlify.app |
Summary
AttributeError: module 'ipyvuetify' has no attribute 'ExpansionPanelHeader'. A newleafmap/vuetify_compat.pymaps the components and props leafmap uses so the widgets work with both ipyvuetify 1.x and 3.x:ExpansionPanelHeader/ExpansionPanelContenttoExpansionPanelTitle/ExpansionPanelText, andTabsItems/TabItemtoTabsWindow/TabsWindowItem.small,left,dense,dark,bottomandbackground_colortosize,start,density,theme,locationandbg_color.variant="text". In Vuetify 3,text=Truerenders the word "true" and icon buttons are raised by default.Containerkeepsmin_widthandmax_widthas Python-only properties. ipyvuetify 3 adds synced traits with these names tov.Container, which clamped the whole container to the sidebar width and hid the map.Test plan
add_sidebar=True) andTabWidgetrender. Expand/collapse, sidebar toggle and tab switching work, and the selected tab syncs back to Python.pytest tests: no new failures. Thetest_plot_raster_issue_1381.pyfailures also happen on master.pre-commit run --all-filespasses.Summary by CodeRabbit