Skip to content

Commit 1171e5b

Browse files
committed
fix:codeql scan Security issue
1 parent 74397d5 commit 1171e5b

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

‎app/src/main/java/com/tinyengine/it/task/DatabaseCleanupService.java‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import jakarta.annotation.PostConstruct;
1414

15-
import lombok.NoArgsConstructor;
1615
import org.slf4j.Logger;
1716
import org.slf4j.LoggerFactory;
1817
import org.springframework.beans.factory.annotation.Autowired;
@@ -42,6 +41,9 @@ public class DatabaseCleanupService {
4241
private static final DateTimeFormatter FORMATTER =
4342
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
4443
private static final int EXEC_ID_LENGTH = 8;
44+
private static final int HEX_NIBBLE_SHIFT = 4;
45+
private static final int HEX_NIBBLE_MASK = 0x0F;
46+
private static final int HEX_RADIX = 16;
4547

4648
private final boolean cleanupEnabled;
4749
private final boolean useTruncate;
@@ -170,8 +172,10 @@ private static String createExecutionId() {
170172
random.nextBytes(randomBytes);
171173
final StringBuilder identifier = new StringBuilder(randomBytes.length * 2);
172174
for (final byte randomByte : randomBytes) {
173-
identifier.append(Character.forDigit((randomByte >>> 4) & 0x0F, 16));
174-
identifier.append(Character.forDigit(randomByte & 0x0F, 16));
175+
identifier.append(
176+
Character.forDigit(
177+
(randomByte >>> HEX_NIBBLE_SHIFT) & HEX_NIBBLE_MASK, HEX_RADIX));
178+
identifier.append(Character.forDigit(randomByte & HEX_NIBBLE_MASK, HEX_RADIX));
175179
}
176180
return identifier.substring(0, EXEC_ID_LENGTH);
177181
}

‎base/src/main/java/com/tinyengine/it/rag/config/ChromaStoreFactory.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88

99
/** Creates Chroma embedding stores from validated connection settings. */
1010
public final class ChromaStoreFactory {
11-
private ChromaStoreFactory() {}
11+
private ChromaStoreFactory() {
12+
}
1213

1314
public static EmbeddingStore<TextSegment> create(
1415
final String baseUrl, final String collectionName, final Duration timeout) {

‎base/src/main/java/com/tinyengine/it/rag/config/VectorStoreConfig.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public EmbeddingStore<TextSegment> embeddingStore() {
105105
logWarn("ChromaDB initialization failed, using fallback embedding store", exception);
106106
}
107107
} else {
108-
logWarn("ChromaDB connection test failed, using fallback embedding store");
108+
logWarn("ChromaDB connection test failed, using fallback embedding store");
109109
}
110110
return embeddingStore;
111111
}

‎base/src/test/java/com/tinyengine/it/common/utils/SM4UtilsTest.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ class SM4UtilsTest {
1313
private static final int SHORT_KEY_LEN = 8;
1414
private final int invalidKeyLength;
1515

16-
/** Initializes the invalid key length used by validation tests. */
17-
public SM4UtilsTest() {
16+
/* default */ SM4UtilsTest() {
1817
invalidKeyLength = SHORT_KEY_LEN;
1918
}
2019

0 commit comments

Comments
 (0)