Skip to content

Commit 51eefe3

Browse files
authored
Merge pull request #9351 from Akshats-git/fix/dist-external-dependencies
Keep dependencies as package imports in the dist build
2 parents 327c20b + 88449aa commit 51eefe3

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎rolldown.config.js‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ const plugins = [
2121
}
2222
)
2323
];
24+
// Dependencies stay as plain package imports in dist/, so the bundler of
25+
// whoever installs p5 can resolve them. gifenc is bundled on purpose.
26+
const bundledDependencies = ['gifenc'];
27+
const externalDependencies = Object.keys(pkg.dependencies).filter(
28+
dep => !bundledDependencies.includes(dep)
29+
);
2430
const banner = `/*! p5.js v${pkg.version} ${new Intl.DateTimeFormat('en-US', { month: 'long', day: 'numeric', year: 'numeric' }).format(new Date())} */`;
2531
export default defineConfig([
2632
{
@@ -113,7 +119,8 @@ export default defineConfig([
113119
format: 'es',
114120
dir: 'dist'
115121
},
116-
external: /node_modules\/(?!gifenc)/,
122+
external: id =>
123+
externalDependencies.some(dep => id === dep || id.startsWith(`${dep}/`)),
117124
plugins
118125
}
119126
]);

0 commit comments

Comments
 (0)