Repository navigation
Commit 15bd4be
committed
Skip the write barrier when the plan has none
rb_gc_impl_writebarrier and rb_gc_impl_writebarrier_remember looked up
the Ractor cache and called into Rust for every store, even for Immix,
MarkSweep and NoGC, whose barrier is NoBarrier and does nothing. Lobsters
runs about 920k barriers per iteration.
In this commit we read the plan's barrier once in objspace_init through
a new mmtk_plan_has_write_barrier, and return before the Ractor cache
lookup and the FFI call when it is NoBarrier. StickyImmix keeps its
object barrier.1 parent 76a2123 commit 15bd4be
3 files changed
Lines changed: 18 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
| |||
619 | 620 | | |
620 | 621 | | |
621 | 622 | | |
| 623 | + | |
622 | 624 | | |
623 | 625 | | |
624 | 626 | | |
| |||
1235 | 1237 | | |
1236 | 1238 | | |
1237 | 1239 | | |
1238 | | - | |
| 1240 | + | |
1239 | 1241 | | |
1240 | 1242 | | |
1241 | 1243 | | |
| |||
1254 | 1256 | | |
1255 | 1257 | | |
1256 | 1258 | | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
1257 | 1262 | | |
1258 | 1263 | | |
1259 | 1264 | | |
| |||
1272 | 1277 | | |
1273 | 1278 | | |
1274 | 1279 | | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
1275 | 1284 | | |
1276 | 1285 | | |
1277 | 1286 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| 93 | + | |
| 94 | + | |
93 | 95 | | |
94 | 96 | | |
95 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
344 | 345 | | |
345 | 346 | | |
346 | 347 | | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
347 | 353 | | |
348 | 354 | | |
349 | 355 | | |
| |||
0 commit comments