fix: migrate npm publishing to OIDC (#109)

Author: susangao21

.eslintignore

@@ -22,9 +22,13 @@ jobs:
       - uses: salesforcecli/github-workflows/.github/actions/getPreReleaseTag@main
         id: distTag
   npm:
+    permissions:
+      id-token: write
+      contents: read
     uses: salesforcecli/github-workflows/.github/workflows/npmPublish.yml@main
     needs: [getDistTag]
     with:
+      trustedPublishing: true
       ctc: true
       sign: true
       tag: ${{ needs.getDistTag.outputs.tag || 'latest' }}

.eslintrc.cjs

@@ -0,0 +1,4 @@
+import salesforce from 'eslint-config-salesforce-typescript';
+import sfPlugin from 'eslint-plugin-sf-plugin';
+
+export default [...salesforce, ...sfPlugin.configs.recommended];

.github/workflows/onRelease.yml

@@ -13,13 +13,19 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^6.0.0",
     "@salesforce/cli-plugins-testkit": "^5.3.39",
-    "@salesforce/dev-scripts": "^11.0.4",
+    "@salesforce/dev-scripts": "^15.0.0",
     "@salesforce/plugin-command-reference": "^3.1.49",
     "@salesforce/ts-types": "^3.0.0",
-    "eslint-plugin-sf-plugin": "^1.20.15",
+    "@types/chai": "^4.3.17",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^18",
+    "@types/sinon": "^10.0.20",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
+    "eslint-plugin-sf-plugin": "^3.0.1",
     "oclif": "^5.0.0",
     "ts-node": "^10.9.2",
-    "typescript": "^5.8.2"
+    "typescript": "^6.0.0"
   },
   "engines": {
     "node": ">=22.0.0"
@@ -126,6 +132,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

eslint.config.mjs

@@ -74,7 +74,7 @@ export class TestReporter {
     }
 
     try {
-      if (result.summary && result.summary.outcome === 'Failed') {
+      if (result.summary?.outcome === 'Failed') {
         process.exitCode = FAILURE_EXIT_CODE;
       }
       switch (options['result-format']) {
@@ -96,8 +96,9 @@ export class TestReporter {
             });
           }
           break;
-        default:
+        case undefined:
           this.logHuman(result, options['detailed-coverage'] as boolean, options['concise'], options['output-dir']);
+          break;
       }
     } catch (e) {
       this.ux.styledJSON(result);
@@ -156,6 +157,8 @@ export class TestReporter {
         resultFormatValue = ResultFormat.human;
       }
 
+      // ResultFormat values not handled here do not require an additional output file.
+      // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check
       switch (resultFormatValue) {
         case ResultFormat.tap:
           outputDirConfig.fileInfos?.push({

package.json

@@ -60,7 +60,7 @@ describe('flow:test:run', () => {
     try {
       // the library writes to a directory, so we need to clean it up :(
       fs.rmSync('myDirectory', { recursive: true });
-    } catch (e) {
+    } catch {
       // do nothing
     }
   });

src/reporters/testReporter.ts

@@ -2,6 +2,7 @@
   "extends": "@salesforce/dev-config/tsconfig-test-strict-esm",
   "include": ["./**/*.ts"],
   "compilerOptions": {
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "types": ["mocha", "node"]
   }
 }

test/.eslintrc.cjs

@@ -4,7 +4,8 @@
     "outDir": "lib",
     "rootDir": "src",
     "skipLibCheck": true,
-    "strictNullChecks": true
+    "strictNullChecks": true,
+    "types": ["mocha", "node"]
   },
   "include": ["./src/**/*.ts"]
 }