Skip to content

provekit/common/src/whir_r1cs: make the witness commitment hiding for full witness ZK. #476

Description

@recmo

On 2026-07-13 in 61744fa “Merge pull request #470 from worldfnd/feat/base-field-witness-commit”:

make the witness commitment hiding for full witness ZK.

    pub num_challenges:    usize,
    pub challenge_offsets: Vec<usize>,
    pub has_public_inputs: bool,
    /// Base-field witness commitment. Non-hiding — WHIR openings leak witness
    /// values, so this provides sumcheck ZK only, not witness ZK.
    /// TODO: make the witness commitment hiding for full witness ZK.
    pub whir_witness:      GenericWhirConfig<P::Embedding>,
    /// Separate ext-field commitment to the Spartan blinding polynomial `g`;
    /// masking the ext-valued sumcheck rounds needs ext randomness, so `g`
    /// cannot ride on the base witness commitment.
    pub whir_blinding:     GenericWhirConfig<Identity<Ext<P>>>,

From provekit/common/src/whir_r1cs.rs:85

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    to doTo do comments in codetracker🤖 issue managed by tracker bot

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions