feat(rust-client, cli): ensure non-fungible assets are fully supported by ricomateo · Pull Request #2688 · 0xMiden/rust-sdk

ricomateo · 2026-10-08T17:52:19Z

Introduces the following changes:

Adds TransactionRequestBuilder helpers to build requests that mint and burn NFAs (build_mint_non_fungible_asset and build_burn_non_fungible_asset).
Changes how the NFAs are displayed in the CLI commands so that they include their faucet and asset ID, and they are separate from fungible tokens.
Adds tests for the NFA minting and burning operations.
Re-exports BurnNote from miden_client::note. The NFA faucet types and factories are available under miden_client::account::standards::faucets.

Closes #2673

…ible_asset helper

…t fail with prologue error

…et ID

… the holding account

…ngible assets

ricomateo · 2026-10-09T21:37:05Z

+                let consumption_status = match consumption_checker
                    .can_consume(
                        account_id,
                        block_ref,
                        InputNote::unauthenticated(note.clone()),
                        account_tx_args.clone(),
                    )
-                    .await?;
+                    .await
+                {
+                    Ok(status) => status,
+                    // If the note consumption tx fails with prologue error, treat the note as not
+                    // consumable
+                    Err(NoteCheckerError::PrologueExecution(_)) => continue,
+                    Err(err) => return Err(err.into()),
+                };


This change was required to fix the note screener bug discussed offline (without this, the mint_and_burn_non_fungible_transaction test fails when screening the burn transaction output notes, failing CI run here).

This probably isn't the right solution for this bug. Perhaps we can undo this fix and remove the failing test for now, create an issue to track the bug, and fix it once we come up with a proper solution.

We should track this with an issue / TODO doc comment.

Yes, let's open an issue for this. For now, I think it's fine to skip notes that error on the prologue. Ideally what we do for checking notes is actually checking against the new state of the account, not the original one. I think this would both be more correct and also would avoid the error.

Created an issue to track this #2699

juan518munoz

LGTM

juan518munoz · 2026-10-13T19:44:35Z

+                let consumption_status = match consumption_checker
                    .can_consume(
                        account_id,
                        block_ref,
                        InputNote::unauthenticated(note.clone()),
                        account_tx_args.clone(),
                    )
-                    .await?;
+                    .await
+                {
+                    Ok(status) => status,
+                    // If the note consumption tx fails with prologue error, treat the note as not
+                    // consumable
+                    Err(NoteCheckerError::PrologueExecution(_)) => continue,
+                    Err(err) => return Err(err.into()),
+                };


We should track this with an issue / TODO doc comment.

igamigo

Left a few minor comments but overall LGTM!

igamigo · 2026-10-14T01:04:30Z

+    /// Consumes the builder and returns a [`TransactionRequest`] for a transaction to mint a
+    /// non-fungible asset. This request must be executed against a non-fungible faucet account.


nit: non-fungible faucet account is fine here, but maybe we could link the actual account components that this transaction relies on.

Done here db7cffe

igamigo · 2026-10-14T01:14:11Z

+    NonFungible {
+        /// The faucet prefix.
+        faucet: String,


I think as of recently we moved away from prefix being the identifier of the faucets (after having removed AccountType::Faucet), so we should be able to rename this from faucet to faucet_id and use that nomenclature instead of "prefix". Could you check that this is consistent in the rest of the CLI's codebase?

igamigo · 2026-10-14T01:37:03Z

+    },
+    NonFungible {
+        /// The faucet prefix.
+        faucet: String,


Additionally (maybe alternatively), I think we could also show the address and/or the symbol slot information here (miden::standards::faucets::non_fungible::symbol). But this is based on the account actually being a standard faucet which may not always be the case

Changed FormatedAsset::NonFungible to include the address and symbol, along with a new method client to fetch the non-fungible faucet symbol here b1f88fe

…_mint_non_fungible_asset docs

…on-fungible asset error instead of all prologue execution errors

…or network faucet

igamigo

LGTM! If we resolve conflicts I think we can merge this

feat(rust-client): add TransactionRequestBuilder::build_mint_non_fung…

1549c8e

…ible_asset helper

ricomateo force-pushed the ricomateo-nfa-readiness branch from 106d3ef to 1549c8e Compare October 8, 2026 18:04

ricomateo added 11 commits October 8, 2026 16:20

feat(rust-client): add TransactionRequestBuilder::build_burn_non_fung…

3f8bff1

…ible_asset helper

fix(rust-client): change NoteScreener::screen_notes to skip notes tha…

266278f

…t fail with prologue error

chore(rust-client): re-export NFA types and helpers

b58dae0

feat(cli): show non-fungible assets in separate tables with their ass…

2ebbe3f

…et ID

test(integration-tests): check NFTs are synced to clients that import…

7fb1758

… the holding account

chore: reuse insert_non_fungible_faucet

133e16c

chore(docs): update changelog

748fc94

feat(cli): label non-fungible faucets and show the asset ID of non-fu…

1fa4b09

…ngible assets

Merge branch 'next' into ricomateo-nfa-readiness

df53d01

refactor(cli): add get_account_kind_from_partial_account

853ed19

Merge branch 'next' into ricomateo-nfa-readiness

bddacf8

ricomateo linked an issue Oct 9, 2026 that may be closed by this pull request

Review client NFA readiness #2673

Closed

ricomateo commented Oct 9, 2026

View reviewed changes

ricomateo changed the title ~~feat(client): NFA readiness~~ feat(rust-client, cli): support NFA lifecycle Oct 9, 2026

ricomateo changed the title ~~feat(rust-client, cli): support NFA lifecycle~~ feat(rust-client, cli): ensure NFAs are fully supported Oct 9, 2026

ricomateo marked this pull request as ready for review October 9, 2026 21:40

ricomateo changed the title ~~feat(rust-client, cli): ensure NFAs are fully supported~~ feat(rust-client, cli): ensure non-fungible assets are fully supported Oct 9, 2026

juan518munoz self-requested a review October 13, 2026 12:47

ricomateo requested review from TomasArrachea and igamigo October 13, 2026 12:48

Merge branch 'next' into ricomateo-nfa-readiness

a29ba61

juan518munoz approved these changes Oct 13, 2026

View reviewed changes

igamigo approved these changes Oct 14, 2026

View reviewed changes

ricomateo added 5 commits October 14, 2026 14:53

Merge branch 'next' into ricomateo-nfa-readiness

4ff3fca

chore(docs): include link to the NonFungibleFaucet component in build…

db7cffe

…_mint_non_fungible_asset docs

chore: change FormattedAsset::NonFungible faucet to faucet_id

51b3cd7

chore: revert "change FormattedAsset::NonFungible faucet to faucet_id"

c29281d

feat: display non-fungible faucet symbol and address

b1f88fe

This was referenced Oct 14, 2026

Note screening uses the initial account state for a transaction's own output notes #2699

Open

feat(web-client): support non-fungible faucets and assets in WebClient 0xMiden/web-sdk#473

Open

ricomateo added 5 commits October 15, 2026 11:27

fix(rust-client): update note screener to ignore only the duplicate n…

fb57315

…on-fungible asset error instead of all prologue execution errors

Merge branch 'next' into ricomateo-nfa-readiness

9aa714c

Merge branch 'next' into ricomateo-nfa-readiness

0e6bd11

Merge branch 'next' into ricomateo-nfa-readiness

3ddc62c

chore(docs): note that build_burn_non_fungible_asset needs a private …

e9209ef

…or network faucet

igamigo approved these changes Oct 16, 2026

View reviewed changes

Merge branch 'next' into ricomateo-nfa-readiness

0f36e9b

ricomateo merged commit af559d2 into next Oct 16, 2026
24 checks passed

ricomateo deleted the ricomateo-nfa-readiness branch October 16, 2026 20:51

		/// Consumes the builder and returns a [`TransactionRequest`] for a transaction to mint a
		/// non-fungible asset. This request must be executed against a non-fungible faucet account.

Conversation

ricomateo commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricomateo Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juan518munoz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igamigo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igamigo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ricomateo commented Oct 8, 2026 •

edited

Loading

ricomateo Oct 9, 2026 •

edited

Loading