Repository navigation
Conversation
ricomateo
added this pull request to stack #476
October 14, 2026 15:53
ricomateo
force-pushed
the
ricomateo-nfa-miden-client
branch
5 times, most recently
from
October 15, 2026 16:57
5858154 to
5f43b2d
Compare
ricomateo
marked this pull request as ready for review
October 15, 2026 17:53
…nt and network note APIs
… isNonFungibleFaucet
ricomateo
force-pushed
the
ricomateo-nfa-miden-client
branch
from
October 15, 2026 18:17
a901dec to
3e2c17f
Compare
ricomateo
changed the title
MidenClient APIMidenClient API
| * note for a public faucet is a network note, so a public faucet must be a | ||
| * network account. | ||
| */ | ||
| async burnNonFungible(opts) { |
Collaborator
There was a problem hiding this comment.
With default settings this can't burn anything. accounts.create makes faucets public by default, and BurnNote adds a NetworkAccountTarget whenever the faucet is public. The e2e test avoids it with storage: "private".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #473
Introduces the following changes
MidenClientfunctions to create non-fungible faucets, mint, send and burn non-fungible assets.NonFungibleAsset.