Repository navigation
feat(workflow): add workflow automation support - #10221
Open
amir-samiee wants to merge 6 commits into
Open
amir-samiee wants to merge 6 commits into
amir-samiee wants to merge 6 commits into
Conversation
amir-samiee
marked this pull request as ready for review
September 23, 2026 14:53
Owner
|
非常感谢 PR，但是暂时还没有考虑合并此功能。 |
Author
|
Thank you very much for your review. Since the request was for some while ago I'm not sure if I'd make the changes you suggested right away; but in case I did, I will absolutely make sure to take the points you made into account. Thanks again for your time. |
Owner
|
要大版本升级了，所以计划合并。
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved workflow bugs can block saves with duplicate subscription names, incorrectly scope all-group operations, and advance steps before server activation or proxy changes complete.
8 open issues
1 file not reviewed
v2rayN/ServiceLib/Resx/ResUI.Designer.cs: Generated file
What changed in this PR
Adds reusable workflows to automate recurring subscription, server-management, testing, and proxy operations through the shared service layer and both desktop interfaces.
Changes:
- Adds persisted workflow definitions, configurable steps, and sequential execution through a runtime interface.
- Adds workflow management and editing windows in WPF and Avalonia, accessible from the main and profiles views.
- Adds tests for serialization, parameter options, action dispatch, and disabled-step handling.
| File | Description |
|---|---|
v2rayN/v2rayN/Views/WorkflowWindow.xaml.cs |
Binds WPF workflow commands and dialogs. |
v2rayN/v2rayN/Views/WorkflowWindow.xaml |
Defines the WPF workflow manager. |
v2rayN/v2rayN/Views/WorkflowEditWindow.xaml.cs |
Binds WPF workflow editing controls. |
v2rayN/v2rayN/Views/WorkflowEditWindow.xaml |
Defines the WPF step editor. |
v2rayN/v2rayN/Views/ProfilesView.xaml.cs |
Binds the workflow shortcut. |
v2rayN/v2rayN/Views/ProfilesView.xaml |
Adds a workflow toolbar button. |
v2rayN/v2rayN/Views/MainWindow.xaml.cs |
Binds the workflow menu command. |
v2rayN/v2rayN/Views/MainWindow.xaml |
Adds the workflow menu entry. |
v2rayN/v2rayN/Common/SimpleViewLocator.cs |
Registers WPF workflow windows. |
v2rayN/v2rayN.Desktop/Views/WorkflowWindow.axaml.cs |
Binds Avalonia workflow commands and dialogs. |
v2rayN/v2rayN.Desktop/Views/WorkflowWindow.axaml |
Defines the Avalonia workflow manager. |
v2rayN/v2rayN.Desktop/Views/WorkflowEditWindow.axaml.cs |
Binds Avalonia step-editing commands. |
v2rayN/v2rayN.Desktop/Views/WorkflowEditWindow.axaml |
Defines the Avalonia step editor. |
v2rayN/v2rayN.Desktop/Views/ProfilesView.axaml.cs |
Binds the workflow shortcut. |
v2rayN/v2rayN.Desktop/Views/ProfilesView.axaml |
Adds a workflow toolbar button. |
v2rayN/v2rayN.Desktop/Views/MainWindow.axaml.cs |
Binds the workflow menu command. |
v2rayN/v2rayN.Desktop/Views/MainWindow.axaml |
Adds the workflow menu entry. |
v2rayN/v2rayN.Desktop/DesignData/DesignData.cs |
Adds workflow design-time view models. |
v2rayN/v2rayN.Desktop/Common/SimpleViewLocator.cs |
Registers Avalonia workflow windows. |
v2rayN/ServiceLib/ViewModels/WorkflowViewModel.cs |
Manages workflow listing, editing, deletion, and execution. |
v2rayN/ServiceLib/ViewModels/WorkflowRuntime.cs |
Connects workflow actions to application operations. |
v2rayN/ServiceLib/ViewModels/WorkflowRunner.cs |
Registers the runtime and starts workflows. |
v2rayN/ServiceLib/ViewModels/WorkflowEditViewModel.cs |
Manages step editing and workflow saving. |
v2rayN/ServiceLib/ViewModels/SubSettingViewModel.cs |
Publishes server-state changes after subscription deletion. |
v2rayN/ServiceLib/ViewModels/ProfilesViewModel.cs |
Adds group-scoped workflow operations and a shortcut command. |
v2rayN/ServiceLib/ViewModels/MainWindowViewModel.cs |
Opens workflow management and registers its runtime. |
v2rayN/ServiceLib/Resx/ResUI.resx |
Adds workflow labels and notifications. |
v2rayN/ServiceLib/Resx/ResUI.Designer.cs |
Exposes workflow resource strings. |
v2rayN/ServiceLib/Models/Entities/WorkflowItem.cs |
Defines persisted workflow records. |
v2rayN/ServiceLib/Models/Dto/WorkflowStep.cs |
Defines step data and editor-facing properties. |
v2rayN/ServiceLib/Manager/AppManager.cs |
Creates workflow storage and provides queries. |
v2rayN/ServiceLib/Helper/WorkflowStepOptions.cs |
Defines parameter choices, defaults, and normalization. |
v2rayN/ServiceLib/Handler/WorkflowHandler.cs |
Serializes steps and dispatches workflow actions. |
v2rayN/ServiceLib/Handler/ConfigHandler.cs |
Adds workflow persistence and deletion. |
v2rayN/ServiceLib/Events/AppEvents.cs |
Adds workflow-opening and server-state events. |
v2rayN/ServiceLib/Enums/EWorkflowAction.cs |
Defines supported workflow actions. |
v2rayN/ServiceLib/Enums/EServerSelectType.cs |
Defines first/last server selection. |
v2rayN/ServiceLib/Base/IWorkflowRuntime.cs |
Defines the workflow execution interface. |
v2rayN/ServiceLib.Tests/Handler/WorkflowHandlerTests.cs |
Covers workflow data, options, and dispatch behavior. |
Review effort: Balanced
Comment on lines
+76
to
+81
| /// <summary> | ||
| /// Editor-only group name. <see cref="ViewModels.WorkflowEditViewModel"/> resolves it | ||
| /// back into <see cref="SubId"/> when the workflow is saved. | ||
| /// </summary> | ||
| [JsonIgnore] | ||
| public string? SubDisplay { get; set; } |
| RxSchedulers.MainThreadScheduler.Schedule(() => _ = SetSpeedTestResult(result)); | ||
| await Task.CompletedTask; | ||
| }); | ||
| await _speedtestService.RunLoop(actionType, lstSelected); |
Comment on lines
+723
to
+725
| var ordered = selectType == EServerSelectType.Last | ||
| ? lstModel.OrderByDescending(t => ProfileExManager.Instance.GetSort(t.IndexId)) | ||
| : lstModel.OrderBy(t => ProfileExManager.Instance.GetSort(t.IndexId)); |
| { | ||
| return; | ||
| } | ||
| await SetDefaultServer(target.IndexId); |
| private async Task ResolveStepSubsAsync() | ||
| { | ||
| var subItems = await AppManager.Instance.SubItems() ?? []; | ||
| var map = subItems.ToDictionary(t => t.Remarks, t => t.Id); |
Comment on lines
+81
to
+85
| step.SubId = step.SubDisplay.IsNotEmpty() | ||
| && step.SubDisplay != ResUI.AllGroupServers | ||
| && map.TryGetValue(step.SubDisplay, out var id) | ||
| ? id | ||
| : null; |
| public async Task<int> DeduplicateServers(string subId) | ||
| { | ||
| var count = await profiles.DedupServersAsync(subId); | ||
| NoticeManager.Instance.Enqueue(string.Format(ResUI.RemoveDuplicateServerResult, count, 0)); |
Comment on lines
+45
to
+46
| AppEvents.SysProxyChangeRequested.Publish(type); | ||
| return Task.CompletedTask; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
I found myself doing more or less the same sequence of actions almost every time I needed the program; and sometimes the items of each step (e.g. servers, subscriptions) were as high as I needed to go and come back to check whether the last step has been completed. As these steps were slightly (or occasionally quite) different based on situation/needs, I found no better way to use the already present features of v2rayN in a workflow-style manner
Testing
WorkflowHandlerTestscoverage for workflow behavior.