Repository navigation
fix: persist repeated profile test results - #10466
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10465.
A new profile is queued when it is created and again when its test result is set. Saving the same new ID twice makes the transactional insert fail with a duplicate primary key, rolling back all new rows and preventing existing results in that batch from being updated.
Deduplicate the drained IDs and save their current records with a transactional insert-or-replace. This also removes the database snapshot used to classify inserts versus updates, which could become stale when saves overlap. Add SQLite-backed regression tests for repeated results across several new profiles and for batches mixing new and existing profiles, including a subsequent update.
Validation:
git diff --checkpass. No live proxy or GUI testing performed.