Repository navigation
fix: match proxy group types without case sensitivity - #10472
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10471.
The current-proxy panel can display a
Selectorgroup, but its batch latency test checks that type against a lowercase allowlist and returns without sending any requests. Match the existing allowed types withStringComparer.OrdinalIgnoreCasesoSelector,URLTest,LoadBalanceandFallbackreach the delay API. Unsupported and missing types remain excluded.The regression test calls the actual ViewModel batch-delay method against a local HTTP server and checks both the request and displayed latency. It covers mixed-case and lowercase group types, plus unsupported and null types. Five of the eight cases fail on unchanged code because no request is sent; all eight pass with the fix.
Validation on Windows with .NET 10.0.401:
ServiceLib.Testssuite: 144 passed, no failures or skips.git diff --check: passed.The desktop UI was not clicked manually and no live proxy core was used; the HTTP regression runs the production ViewModel and API-client path with a controlled delay response.