Improve testing for Muon and the sharded Muon variant. - #5029
Open
copybara-service[bot] wants to merge 1 commit into
Open
Improve testing for Muon and the sharded Muon variant.#5029copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 27, 2026 18:16
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Renames and generalizes MuonDimensionNumbers to ShardedMuonDimensionNumbers with optional NamedSharding specification (and preserves backward-compatible alias). - Fixes Newton-Schulz coefficient length check in muon.py to raise ValueError when fewer coefficients than steps are provided, and slices trailing coefficients when extra coefficients are provided. - Moves muon_test.py and muon_sharding_test.py from src/maxtext/optimizers/ to tests/unit/ to conform to MaxText open-source directory conventions. - Adds test cases in muon_test.py for coefficient schedule slicing and insufficient coefficient error handling, and configures muon_sharding_test.py with an isolated subprocess test runner. PiperOrigin-RevId: 972054201
copybara-service
Bot
force-pushed
the
test_972054201
branch
from
August 27, 2026 18:25
7e832fb to
f4e91fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve testing for Muon and the sharded Muon variant.