[Maxtext][Tunix] Fix Weight Conversion for Qwen3.5-35B - #5045
[Maxtext][Tunix] Fix Weight Conversion for Qwen3.5-35B#5045YixuanWang-99 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates MaxText with Tunix and Raiden weight synchronization for RL post-training. Key changes include re-exporting Tunix's shared trainer data types to avoid type mismatches, refactoring MaxTextTrainingEngine to support dynamic/static batch splitting for JIT compilation, and implementing chunked Raiden weight synchronization to prevent host memory OOMs. Additionally, the weight conversion and validation pipelines are updated to align with production rollout behavior. Review feedback suggests treating nnx.Param as a leaf during tree_map in unscan_layers to avoid double-wrapping, and converting nnx.State to a standard dictionary before flattening in _split_into_chunks to ensure robustness against future Flax NNX refactorings.
27902b5 to
af235d0
Compare
08a81fc to
f748fb4
Compare
4738a55 to
d5e1e01
Compare
d5e1e01 to
4521fc5
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Description
This is the new weight converter between maxtext and tunix vllm rollout engine, tests passed.
Key changes
Tests
We have two conversion modes:
Then we have e2e test for post_train/train_rl 10 step smoke tests also passed:
To vllm maxtext layout, Standalone tests passed, E2E test is ongoing:
To vllm native HF layout, Standalone tests passed, E2E test is ongoing:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.