Skip to content

Run pre-commit to fix MaxText linter - #5049

Open
bvandermoon wants to merge 1 commit into
mainfrom
bvandermoon-github-deps
Open

Run pre-commit to fix MaxText linter#5049
bvandermoon wants to merge 1 commit into
mainfrom
bvandermoon-github-deps

Conversation

@bvandermoon

@bvandermoon bvandermoon commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

CI lint tests are failing. This PR was auto-generated by pre-commit run --all-files to fix the lint issues.

Tests

CI tests (auto-generated linter only)

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily reformats the codebase by unwrapping several multi-line statements into single lines across various model, layer, and test files. The review feedback suggests merging implicitly concatenated string and f-string literals that are now on single lines into unified string literals to improve code readability and simplicity.

Comment thread src/maxtext/layers/moe.py Outdated
Comment thread tests/unit/router_replay_test.py Outdated
Comment thread tests/unit/router_replay_test.py Outdated
Comment thread tests/post_training/unit/router_replay_engine_test.py Outdated
@bvandermoon
bvandermoon force-pushed the bvandermoon-github-deps branch from 62745fc to 42e0e79 Compare August 28, 2026 22:27
@bvandermoon
bvandermoon force-pushed the bvandermoon-github-deps branch from 42e0e79 to 376ec14 Compare August 28, 2026 22:29
NuojCheng
NuojCheng approved these changes Aug 28, 2026
View reviewed changes

@NuojCheng NuojCheng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@codecov

codecov Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/moe.py 90.90% 2 Missing ⚠️
src/maxtext/layers/nnx_decoders.py 75.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darisoy darisoy darisoy approved these changes
@SurbhiJainUSC SurbhiJainUSC SurbhiJainUSC approved these changes
@NuojCheng NuojCheng NuojCheng approved these changes
@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner
@michelle-yooh michelle-yooh Awaiting requested review from michelle-yooh michelle-yooh is a code owner
@gagika gagika Awaiting requested review from gagika gagika is a code owner
@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner
@shralex shralex Awaiting requested review from shralex shralex is a code owner
@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git is a code owner
@shuningjin shuningjin Awaiting requested review from shuningjin shuningjin is a code owner
@zxhe-sean zxhe-sean Awaiting requested review from zxhe-sean zxhe-sean is a code owner
@parambole parambole Awaiting requested review from parambole parambole is a code owner
@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner
@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner
@xibinliu xibinliu Awaiting requested review from xibinliu xibinliu is a code owner
@huytransformer huytransformer Awaiting requested review from huytransformer huytransformer is a code owner
@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner
@abhinavclemson abhinavclemson Awaiting requested review from abhinavclemson abhinavclemson is a code owner
@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner
@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner
@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner
@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner
@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bvandermoon @darisoy @SurbhiJainUSC @NuojCheng