Skip to content

feat: ParamStore::update polyfill without host push #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kosmar wants to merge 1 commit into from
Closed

feat: ParamStore::update polyfill without host push #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions faderpunk/src/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,25 @@ impl<P: AppParams> ParamStore<P> {
accessor(&*guard)
}

/// Change a param from inside the app and persist it to FRAM.
///
/// Same call shape as the full AppParams writeback (#640), but without the
/// host push: the configurator stays stale until that lands. Apps can call
/// this now; swapping in the real #640 implementation later is a drop-in.
#[allow(dead_code)]
pub async fn update<F>(&self, modifier: F)
where
F: FnOnce(&mut P),
{
{
let mut inner = self.inner.borrow_mut();
modifier(&mut inner);
}
self.save().await;
// #640 adds: try_send AppState on APP_PARAM_PUSH_CHANNEL so the host
// tracks on-device edits live.
}

pub async fn param_handler(&self) {
APP_PARAM_SIGNALS[self.layout_id as usize].reset();
loop {
Expand Down