fix: recognize FPApp tooling in scope checks - #665
Merged
ArthurGibert merged 3 commits intoSep 4, 2026
Merged
Conversation
Teach the pull-request classifier that fpapp is first-party build tooling and fpapp-sdk is part of the shared protocol surface. This keeps future native-app work from being mistaken for an unrelated standalone project.\n\nDocument both directories in the contributor categories and add a Linux-tested regression fixture covering them together.
This was referenced Aug 29, 2026
The soft-flag only fired for App-category PRs, so a PR touching only libfp/src/** or fpapp-sdk/** got zero soft-flags despite CONTRIBUTING.md's "always flagged for a manual look" claim. Extend the test harness to assert on soft-flag content, not just hard-fail count, so this can't regress silently again. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Type
Description
The PR scope check currently treats two planned first-party directories as if
they were unrelated projects:
fpapp/, the command-line package builder;fpapp-sdk/, the small ABI facade used by native community apps.That makes the scope report misleading before it has even looked at the code.
This focused prerequisite teaches the classifier what those directories mean.
The builder is classified as project tooling, while the SDK is classified with
the shared protocol surface because changing it affects both firmware and apps.
This PR does not add the FPApp runtime or change the firmware. It only makes
the existing review gate understand the new first-party areas. Keeping this
separate means the classifier change can be reviewed and merged on its own,
before the larger feature PR.
The contributor table now says the same thing as the script, and a synthetic
fixture protects both paths from regressing back to “unrecognized.”
Scope acknowledgement
Verification
.github/scripts/pr-scope-check.test.shin Ubuntu 24.04 with GNU Bash, GNU sed, and jq: 17 passed, 0 failed.