Skip to content

chore: bump checkout@v2->v4 and setup-python@v1->v5 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Jul 11, 2026
Merged

chore: bump checkout@v2->v4 and setup-python@v1->v5 #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
python_version: ['3.12']
steps:
- name: Checkout 🛎️
uses: actions/checkout@v2 # If you're using actions/checkout@v2 you must set persist-credentials to false in most cases for the deployment to work correctly.
uses: actions/checkout@v4 # persist-credentials must be false so the deploy step below uses its own token, not the checkout credentials.

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the Node 24 checkout action

This workflow is being updated to address the Node 20 deprecation, but actions/checkout@v4 still declares runs.using: node20 in its action metadata; the Node 24-compatible release is actions/checkout@v5. In scheduled/master deploy runs this will continue to emit the same Node 20 warning and leaves the checkout step exposed to the planned Node 20 runner removal, so this line should be bumped to actions/checkout@v5 instead.

Useful? React with 👍 / 👎.

@greptile-apps greptile-apps Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Submodule Cleanup Can Fail

When checkout@v4 runs with submodules: 'recursive' and persist-credentials: false, the checkout action still performs submodule credential cleanup in its post-job step. If the submodule worktree or .gitmodules state is not available in the shape that cleanup expects, the build and deploy can finish successfully but the workflow can still fail during post-job cleanup.

with:
submodules: 'recursive'
persist-credentials: false

- name: Setup Python
uses: actions/setup-python@v1
uses: actions/setup-python@v5

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the Node 24 setup-python action

actions/setup-python@v5 also still declares runs.using: node20 in its action metadata; the Node 24-compatible release is actions/setup-python@v6. Since this workflow's Python setup runs on every scheduled/push build, the current bump does not actually remove the Node 20 deprecation exposure for this step, so it should target actions/setup-python@v6.

Useful? React with 👍 / 👎.

with:
python-version: ${{ matrix.python_version }}

Expand Down
Loading