Conversation
✅ Deploy Preview for cell-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rugeli
commented
Sep 17, 2026
Comment on lines
+40
to
52
| // pulls the numeric video id out of any vimeo.com url | ||
| export const getVimeoVideoId = (url: string): string | null => { | ||
| const match = url.match(/vimeo\.com\/(?:.*\/)?(\d+)(?:[/?#]|$)/); | ||
| return match ? match[1] : null; | ||
| }; | ||
|
|
||
| // rewritten vimeo url to the embeddable player form | ||
| export const getVideos = (rawMedia?: MediaFrontmatter): RawVideoData[] => { | ||
| return rawMedia?.videos || []; | ||
| return (rawMedia?.videos ?? []).map((v) => { | ||
| const id = getVimeoVideoId(v.video); | ||
| return id ? { ...v, video: `https://player.vimeo.com/video/${id}` } : v; | ||
| }); | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
these are the only new lines, the rests are formatting
interim17
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
Help Sara to get the vimeo videos to render correctly on the site.
Solution
What I/we did to solve this problem
add a helper pulls the numeric video ids out of
vimeo.comurls and write the id tohttps://player.vimeo.com/video/<id>Type of change
Please delete options that are not relevant.
Steps to Verify: