Skip to content

Set a maximum session age of 1 day for Django admin - #1645

Merged
ramonavic merged 2 commits into
Amsterdam:mainfrom
delta10:fix/session-cookie-age
Oct 19, 2026
Merged

ramonavic merged 2 commits into
Amsterdam:mainfrom
delta10:fix/session-cookie-age

Conversation

@bartjkdp

Copy link
Copy Markdown
Contributor

Description

This change sets a maximum session age of 1 day for Django admin. The current age is 2 weeks.

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations
  • PR was created with the "Allow edits and access to secrets by maintainers" checkbox checked

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

@bartjkdp
bartjkdp force-pushed the fix/session-cookie-age branch from 790a8f7 to eaf2ed9 Compare September 25, 2026 09:22
@ramonavic

Copy link
Copy Markdown
Contributor

Hi @bartjkdp, het is helaas een beetje druk dus we kwamen nog niet toe aan de PR's.
De komende sprint (2 weken) zitten ook behoorlijk vol dus ik kan niet beloven dat we aan alle open PR's toekomen.

Dit lijkt me sowieso een goede fix en heb ik alvast geapproved.
Hij moet nog wel even gerebased worden.

Dank voor je ondersteuning!

@bartjkdp

bartjkdp commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@ramonavic geen probleem hoor, doe rustig aan. Deze kwam bij ons uit een recente pentest, maar er zit niets met hoge prio tussen. Ik heb deze alvast bijgewerkt.

@ramonavic
ramonavic merged commit 1c8d512 into Amsterdam:main Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants