Repository navigation
Add support for Name.com - #1212
Merged
Merged
Conversation
giuseongit
force-pushed
the
feature/namecom
branch
from
April 24, 2022 20:27
d233bd0 to
f2fbc74
Compare
Name.com API docs: https://www.name.com/api-docs/DNS
giuseongit
force-pushed
the
feature/namecom
branch
from
April 24, 2022 20:45
f2fbc74 to
b94a5d6
Compare
Collaborator
|
Hello @giuseongit, do you need some help to troubleshoot the test failures on Python 3.7? |
Contributor
Author
|
@adferrand yes please, I thought that changing some tests could resolve this issue, but I cannot make the tests pass |
Collaborator
|
No big deal, the internals of |
Collaborator
|
I can live with the internal http session in the provider. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name.com API docs: https://www.name.com/api-docs/DNS
This is a follow-up of #507. I've worked an all the comments except for #507 (comment) and #507 (comment).
I've seen that the tests are slightly changed, so I've fixed that too.
pinging @adferrand as he was the reviewer of the previous pr