Skip to content

Add support for Name.com - #1212

Merged
adferrand merged 2 commits into
AnalogJ:masterfrom
giuseongit:feature/namecom
May 6, 2022
Merged

adferrand merged 2 commits into
AnalogJ:masterfrom
giuseongit:feature/namecom

Conversation

@giuseongit

Copy link
Copy Markdown
Contributor

Name.com API docs: https://www.name.com/api-docs/DNS

This is a follow-up of #507. I've worked an all the comments except for #507 (comment) and #507 (comment).
I've seen that the tests are slightly changed, so I've fixed that too.

pinging @adferrand as he was the reviewer of the previous pr

@adferrand

Copy link
Copy Markdown
Collaborator

Hello @giuseongit, do you need some help to troubleshoot the test failures on Python 3.7?

@giuseongit

Copy link
Copy Markdown
Contributor Author

@adferrand yes please, I thought that changing some tests could resolve this issue, but I cannot make the tests pass

@adferrand

Copy link
Copy Markdown
Collaborator

No big deal, the internals of unittest.mock have changed between Python 3.7 and 3.9. It is better to use unitest.mock.call to check mocked calls since the class will cover this discrepencies in term of implementation for you.

@adferrand

Copy link
Copy Markdown
Collaborator

I can live with the internal http session in the provider. LGTM!

@adferrand
adferrand merged commit e5ea281 into AnalogJ:master May 6, 2022
@giuseongit
giuseongit deleted the feature/namecom branch May 6, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants