Repository navigation
Firmware fixes: BLE power with proxy off, humidity offset correction, warm-up gate, Estimated Room names, OTA encryption note - #151
Closed
TrevorSchirmer wants to merge 6 commits into
Closed
TrevorSchirmer wants to merge 6 commits into
TrevorSchirmer wants to merge 6 commits into
Conversation
The switch only paused the BLE scanner, so the BLE stack stayed powered and the unit kept most of the radio's power draw and self-heating with the proxy off. Start esp32_ble with enable_on_boot: false and have the switch (and the on_boot re-apply, which also runs on every deep-sleep wake) enable the stack and scan when on, and stop scanning and disable the stack when off. AIR-1_BLE keeps RESTORE_DEFAULT_ON, so legacy BLE devices still come up proxying. The Factory image keeps the stack powered (ble_always_on) so Improv-over-BLE provisioning keeps working. Fixes #130
The SEN55 Temperature Offset corrects for enclosure self-heating, but humidity was left as measured at the warmer internal temperature, so it read several points low. Re-reference RH to the offset-corrected temperature at constant vapour pressure (Magnus formula, same coefficients as Predicted_Room.yaml) using the unfiltered SEN55 temperature from the same read, then subtract the flat humidity offset and clamp to 0-100. NaN inputs fall back to the uncorrected value. Fixes #145
The first SEN55 temperature and humidity readings after power-up are off while the sensor and enclosure settle. Add a warm-up gate as the first filter on both sensors that drops values for the first 3 minutes after boot, the same window the room estimate sensors use. The gate only applies while deep sleep is prevented (Prevent Sleep or OTA Mode). A sleeping unit is awake about 2 minutes per cycle and would otherwise never report temperature or humidity. Dropped values never reach the later filters, so the humidity correction and offsets only see post-warm-up readings. Fixes #147
The two sensors are a sensor-fusion estimate of current room conditions with self-heating compensation, not a forecast. Rename them to "Estimated Room Temperature" and "Estimated Room Humidity" and update the comment wording to match. The C++ ids (predicted_room_temperature, predicted_room_humidity) and the package file name are unchanged. Both sensors are disabled by default and only on beta so far; users who enabled them will get new Home Assistant entities and can delete the old ones. Fixes #141
The packaged OTA entry sets the default password. Add a comment next to the ota_password substitution showing the two-flash migration from device YAML, extending the packaged entry (ota_esphome) instead of adding a second one: 1. Keep the password and add encryption with allow_plaintext_upload, so the running firmware's password prompt can still be answered on the plaintext upload (ESPHome allows password + encryption only in this migration form, and does not build the password in). 2. Remove the password and drop allow_plaintext_upload. No behaviour change. Fixes #137
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
2 of 10 tasks
TrevorSchirmer
pushed a commit
that referenced
this pull request
Nov 17, 2026
2 of 10 tasks
Member
Author
|
Folded into #150, which now carries these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.11.15.2
What does this implement/fix?
A batch of small firmware fixes:
esp32_blenow hasenable_on_boot: false. Turning the switch on enables the stack and starts continuous scanning. Turning it off stops the scan and disables the stack, so a unit with the proxy off no longer carries the radio's power draw and self-heating. The boot-time re-apply (on_bootpriority -300) uses the same scripts. AIR-1_BLE still defaults the proxy to ON (RESTORE_DEFAULT_ON). The Factory image keeps the stack powered (ble_always_on: "true") for Improv-over-BLE but still stops scanning while the proxy is off.ota_esphome. No behaviour change.The ESP Temperature difference with the proxy off still needs a check on hardware.
Fixes #130
Fixes #145
Fixes #147
Fixes #141
Fixes #137
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified: