-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Skip redirect set lookup for non-3xx responses #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hyperxpro
merged 3 commits into
AsyncHttpClient:main
from
maygemdev:fix/avoid-boxing-on-redirect-status-check
Aug 5, 2026
+64
−1
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...src/test/java/org/asynchttpclient/netty/handler/intercept/Redirect30xInterceptorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Copyright (c) 2026 AsyncHttpClient Project. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.asynchttpclient.netty.handler.intercept; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| /** | ||
| * Tests {@link Redirect30xInterceptor#isRedirect(int)}: the 3xx class check and the | ||
| * {@link Redirect30xInterceptor#REDIRECT_STATUSES} membership must agree, so a 3xx that is not a followed | ||
| * redirect is rejected just like a non-3xx status. | ||
| */ | ||
| public class Redirect30xInterceptorTest { | ||
|
|
||
| @Test | ||
| public void acceptsTheFollowedRedirectStatuses() { | ||
| for (int statusCode : new int[]{301, 302, 303, 307, 308}) { | ||
| assertTrue(Redirect30xInterceptor.isRedirect(statusCode), statusCode + " should be a redirect"); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void rejects3xxStatusesThatAreNotFollowed() { | ||
| // in the 3xx class, but not redirects this interceptor acts on: 304 in particular must fall through | ||
| // to the normal response path rather than be treated as a redirect | ||
| for (int statusCode : new int[]{300, 304, 305, 306, 399}) { | ||
| assertFalse(Redirect30xInterceptor.isRedirect(statusCode), statusCode + " should not be a redirect"); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void rejectsStatusesOutsideThe3xxClass() { | ||
| for (int statusCode : new int[]{100, 200, 204, 299, 400, 404, 500}) { | ||
| assertFalse(Redirect30xInterceptor.isRedirect(statusCode), statusCode + " should not be a redirect"); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.