feat(notifications): render the weekly_rotation notification - #14594
Merged
Merged
Conversation
The api now writes a `weekly_rotation` notification row per active listener every Wednesday, and pedalboard pushes it. This makes the row show up in the notification feed on web and mobile as "Your Weekly Rotation Is Ready", opening the viewer's own mix, and routes the push tap (`type: 'WeeklyRotation'`) to the WeeklyRotationScreen. The SDK's generated union doesn't know the type yet, so the adapter maps it in the same fallback branch remix_contest_update used before its regen. Both tiles hide while the `weekly_rotation` flag is off: the page they open bounces to Explore in that state, and the server fans the row out regardless. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The api is adding a
weekly_rotationnotification row per active listener every Wednesday (AudiusProject/api#1038) and pedalboard pushes it (AudiusProject/pedalboard#94). Without this the row is dropped by the adapter and a push tap opens the app to nothing.What
NotificationType.WeeklyRotation(+ the push enum) andWeeklyRotationNotification { year, week }in common; adapter mapsweekly_rotationin the pre-regen fallback branch (same pathremix_contest_updatetook), so no SDK regen is needed./explore/weekly-rotation.WeeklyRotationScreen;useNotificationNavigationgets aWeeklyRotationhandler, which also covers the push payload.weekly_rotationis off, since the page they open redirects to Explore in that state.Verification
tscfor common, web and mobile; eslint on the touched files. No device run: the tile is a plain navigation, and the screen it opens shipped in #14587.🤖 Generated with Claude Code