Skip to content

fix(ci): skip mobile workspace patches when mobile node_modules is absent - #14659

Merged
dylanjeffers merged 1 commit into
mainfrom
fix/workspace-patches-web-cache
Oct 9, 2026
Merged

dylanjeffers merged 1 commit into
mainfrom
fix/workspace-patches-web-cache

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Web Build on main fails on a node_modules cache hit:

Error: Patch file found for package lottie-react-native which is not present at node_modules/lottie-react-native

The Lottie patch from #14652 lives in packages/mobile/workspace-patches because npm nests that package under packages/mobile/node_modules. web.yml's cache doesn't include that folder, so on a cache hit the package is missing and --error-on-fail exits. The mobile workflow caches the folder, so mobile builds are unaffected.

The step now runs only when packages/mobile/node_modules exists. Full installs still apply the patch.

🤖 Generated with Claude Code

…les is missing

Web CI's node_modules cache doesn't include packages/mobile/node_modules, so a
cache hit failed postinstall on the lottie-react-native patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6beca27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers

Copy link
Copy Markdown
Contributor Author

Verified locally by reproducing a web cache hit (root and web workspace node_modules, no packages/mobile/node_modules): the old script exits 1 with the same lottie-react-native error as CI, and this script exits 0. Web CI doesn't run on scripts/ changes.

@dylanjeffers
dylanjeffers merged commit 39ebf0e into main Oct 9, 2026
3 checks passed
@dylanjeffers
dylanjeffers deleted the fix/workspace-patches-web-cache branch October 9, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant