[mvacula02]

ARO-27733
ARO-30532

What

Adds an E2E test that verifies ARO HCP clusters can register with console.redhat.com via the Insights Operator. The test creates a cluster, confirms the Insights Operator is in NoToken/disabled state (no cloud.openshift.com token in openshift-config/pull-secret), adds a cloud.openshift.com pull secret to kube-system/additional-pull-secret, waits for HCCO to merge it into global-pull-secret, and verifies the Insights Operator transitions to Available=True, Degraded=False.

The test skips gracefully if the pull-secret file is missing or does not contain a cloud.openshift.com token. If the Insights Operator is unexpectedly already Available before the token is added, the test also skips since the NoToken-to-healthy transition cannot be verifiedin that case.

Why

The Insights Operator on ARO HCP previously never registered clusters with console.redhat.com because it only checked openshift-config/pull-secret for the cloud.openshift.com token, which on ARO HCP only contains ACR registry credentials. Customers add their Red Hat pull secret day-2 via kube-system/additional-pull-secret, and HCCO merges it into global-pull-secret, but the Insights Operator didn't look there.

This was fixed by the Insights team in OCPBUGS-87889 (openshift/insights-operator#1302), which adds a fallback to kube-system/global-pull-secret. This test provides E2E coverage for that fix to prevent regressions and ensure the end-to-end flow works on ARO HCP

Testing

This is a new E2E test, and a new test verifier.

• Unit tests
• Integration tests
• E2E tests

PR Checklist

• revert MustFilter
• PR is scoped to a single task (no mixed concerns)
• Title follows Conventional Commits format
• Summary explains the "Why" behind the change
• Linked to relevant ticket/issue
• Screenshots included (if dashboards or other UI changes)
• Self-reviewed the diff
• CI/CD checks are passing (ignore Tide)
• Draft PR used for WIP (if applicable)
• Commit history is clean (rebased/squashed)
• Tricky code blocks are commented
• Specific reviewers tagged
• All comment threads resolved before merge

If E2E tests are included:

• E2E tests follow Principles of Good E2E Test Case Design
• If new E2E use case is covered (via a new test or new check/verifier),
  demonstrate that the test is able to detect a defect/error and fail with
  proper error message and logs which communicates nature of the problem.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mvacula02]

/test e2e-parallel

[mvacula02]

/test e2e-parallel

[mvacula02]

/test integration-e2e-parallel

[mvacula02]

/test integration-e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvacula02
Once this PR has been reviewed and has the lgtm label, please assign patriksuba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mvacula02]

/test e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[mvacula02]

/test e2e-parallel

[mvacula02]

/test e2e-parallel

[mvacula02]

/test e2e-parallel

[mvacula02]

/test verify lint

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[mvacula02]

/test verify lint e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[mvacula02]

/test e2e-parallel

[mvacula02]

/test e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[mvacula02]

/test e2e-parallel

[mvacula02]

/test integration-e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[mvacula02]

/test e2e-parallel

[mvacula02]

/test integration-e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[mvacula02]

/test e2e-parallel integration-e2e-parallel

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[mvacula02]

/test e2e-parallel integration-e2e-parallel

[openshift-ci]

mvacula02: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-e2e-parallel	a3f5fc0	link	false	/test integration-e2e-parallel
ci/prow/e2e-parallel	a3f5fc0	link	true	/test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.