Repository navigation
fix(e2e): stop timing report iframe resize feedback (AROSLSRE-2698) - #7897
Conversation
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the viewport-based sizing change addressing embedded timing report growth.
No open issues 🎉
What changed in this PR
Fixes continuous growth of embedded E2E timing reports by sizing the overview independently of the iframe’s content height.
Changes:
- Uses the accessible outer browser viewport, with a fixed 320px fallback when cross-origin restrictions prevent access.
- Handles host viewport resizing while preserving row and time zoom.
- Adds auto-height iframe regression coverage and documents embedding behavior.
| File | Description |
|---|---|
test/e2e/README.md |
Documents viewport-based sizing and the cross-origin fallback. |
test/cmd/aro-hcp-tests/visualize/options.go |
Updates overview sizing and host resize handling. |
test/cmd/aro-hcp-tests/visualize/options_test.go |
Tests iframe stability, host resizing, zoom preservation, and overview restoration. |
Review effort: Balanced
|
Scheduling tests matching the |
|
/override ci/prow/e2e-parallel This PR only fixes a bug in the Test Timming Analysis display, does not affects the E2E code and the last E2E failed in a totally unrelated issue. |
|
Rael Garcia (@raelga): Overrode contexts on behalf of raelga: ci/prow/e2e-parallel DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga, venkateshsredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AROSLSRE-2698
What
Sizes the timing overview from the accessible outer browser viewport rather than a content-sized iframe. Uses a fixed 320px overview when cross-origin restrictions prevent access to that viewport. Responds to host viewport resizes while preserving row and time zoom.
Adds an auto-height iframe regression and documents the embedding behavior.
Why
Prow sizes HTML artifact iframes from their content height. Using that iframe's
window.innerHeightto determine chart height creates a resize feedback loop: the report's 30px footer exceeds its 16px reserved space, adding 14px per cycle. The bars grow continuously and make the page unusable.The failure is reproducible in Stage run 2117146449132130304.
Testing
go test ./test/cmd/aro-hcp-tests/visualize -count=1 -vpasses with Node v26.13.0 available.In the fixed Prow embedding, selecting 20–40% of tests expands the chart to 676px; restoring the full range settles at 549px. The cross-origin browser check confirms that top-level viewport access is actually denied.
Special notes for your reviewer
The fix applies to newly generated reports. Existing Prow artifacts contain their own embedded JavaScript and require regeneration to receive it. Opening an existing report directly avoids the auto-height iframe feedback loop.
Before: the same 100-test Prow report grows beyond the viewport without interaction.
After: the generated viewport-sizing fix keeps the overview stable.
PR Checklist
If E2E tests are included: