Skip to content

fix(build): ignore templatize temp files in dockerignore - #7923

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
dockerfile-ignore-templatize
Nov 3, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
mainfrom
dockerfile-ignore-templatize

Conversation

@janboll

Copy link
Copy Markdown
Collaborator

What

Prevents a race condition during concurrent builds where podman crashes trying to copy ephemeral templatize binaries that were just deleted by another make job.

Testing

Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.

Describe the testing provided. If you did not add tests, provide a clear
justification.

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if dashboards or other UI changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

If E2E tests are included:

  • E2E tests follow Principles of Good E2E Test Case Design
  • If new E2E use case is covered (via a new test or new check/verifier),
    demonstrate that the test is able to detect a defect/error and fail with
    proper error message and logs which communicates nature of the problem.

Prevents a race condition during concurrent builds where podman crashes trying to copy ephemeral templatize binaries that were just deleted by another make job.
Copilot AI balanced review requested due to automatic review settings November 3, 2026 09:02
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci openshift-ci Bot added area/admin Automatically applied by owners-label for area/admin area/backend Automatically applied by owners-label for area/backend area/fleet Automatically applied by owners-label for area/fleet approved area/frontend Automatically applied by owners-label for area/frontend area/kube-applier Automatically applied by owners-label for area/kube-applier area/tooling Automatically applied by owners-label for area/tooling labels Nov 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the exclusions intended to prevent container build failures involving temporary templatize binaries.

No open issues 🎉

What changed in this PR

This PR excludes temporary templatize binaries from ARO-HCP container build contexts to prevent Podman copy failures when concurrent make jobs delete those files.

Changes:

  • Adds tooling/templatize/templatize-* to ten Dockerfile-specific ignore files.
  • Applies the same exclusion across service and tooling image builds.
File Description
tooling/​tenant-quota/​Dockerfile.dockerignore Excludes temporary binaries from tenant-quota builds.
tooling/​aro-hcp-exporter/​Dockerfile.dockerignore Excludes temporary binaries from exporter builds.
swift-recorder/​Dockerfile.dockerignore Excludes temporary binaries from swift-recorder builds.
sessiongate/​Dockerfile.dockerignore Excludes temporary binaries from sessiongate builds.
mgmt-agent/​Dockerfile.dockerignore Excludes temporary binaries from management-agent builds.
kube-applier/​Dockerfile.dockerignore Excludes temporary binaries from kube-applier builds.
frontend/​Dockerfile.dockerignore Excludes temporary binaries from frontend builds.
fleet/​Dockerfile.dockerignore Excludes temporary binaries from fleet builds.
backend/​Dockerfile.dockerignore Excludes temporary binaries from backend builds.
admin/​Dockerfile.dockerignore Excludes temporary binaries from admin builds.

Review effort: Balanced

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-parallel

@venkateshsredhat

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janboll, venkateshsredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 2c9e036 into main Nov 3, 2026
24 checks passed
@openshift-merge-bot
openshift-merge-bot Bot deleted the dockerfile-ignore-templatize branch November 3, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/admin Automatically applied by owners-label for area/admin area/backend Automatically applied by owners-label for area/backend area/fleet Automatically applied by owners-label for area/fleet area/frontend Automatically applied by owners-label for area/frontend area/kube-applier Automatically applied by owners-label for area/kube-applier area/tooling Automatically applied by owners-label for area/tooling lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants