Repository navigation
fix(build): ignore templatize temp files in dockerignore - #7923
Conversation
Prevents a race condition during concurrent builds where podman crashes trying to copy ephemeral templatize binaries that were just deleted by another make job.
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the exclusions intended to prevent container build failures involving temporary templatize binaries.
No open issues 🎉
What changed in this PR
This PR excludes temporary templatize binaries from ARO-HCP container build contexts to prevent Podman copy failures when concurrent make jobs delete those files.
Changes:
- Adds
tooling/templatize/templatize-*to ten Dockerfile-specific ignore files. - Applies the same exclusion across service and tooling image builds.
| File | Description |
|---|---|
tooling/tenant-quota/Dockerfile.dockerignore |
Excludes temporary binaries from tenant-quota builds. |
tooling/aro-hcp-exporter/Dockerfile.dockerignore |
Excludes temporary binaries from exporter builds. |
swift-recorder/Dockerfile.dockerignore |
Excludes temporary binaries from swift-recorder builds. |
sessiongate/Dockerfile.dockerignore |
Excludes temporary binaries from sessiongate builds. |
mgmt-agent/Dockerfile.dockerignore |
Excludes temporary binaries from management-agent builds. |
kube-applier/Dockerfile.dockerignore |
Excludes temporary binaries from kube-applier builds. |
frontend/Dockerfile.dockerignore |
Excludes temporary binaries from frontend builds. |
fleet/Dockerfile.dockerignore |
Excludes temporary binaries from fleet builds. |
backend/Dockerfile.dockerignore |
Excludes temporary binaries from backend builds. |
admin/Dockerfile.dockerignore |
Excludes temporary binaries from admin builds. |
Review effort: Balanced
|
Scheduling tests matching the |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janboll, venkateshsredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
Prevents a race condition during concurrent builds where podman crashes trying to copy ephemeral templatize binaries that were just deleted by another make job.
Testing
Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.
Describe the testing provided. If you did not add tests, provide a clear
justification.
Special notes for your reviewer
PR Checklist
If E2E tests are included:
demonstrate that the test is able to detect a defect/error and fail with
proper error message and logs which communicates nature of the problem.