Repository navigation
[AutoPR @azure-provisioning-webpubsub]-generated-from-SDK Generation - JS-7026014 - #40598
Merged
Qiaoqiao Zhang (qiaozha) merged 12 commits intoNov 4, 2026
Merged
Qiaoqiao Zhang (qiaozha) merged 12 commits into
Qiaoqiao Zhang (qiaozha) merged 12 commits into
Conversation
…ignalRService/SignalRService/tspconfig.yaml', and CommitSHA: 'a75e2ce569b3404a4da366dc98357581fd67fe21' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=7026014 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
|
Azure Pipelines: Successfully started running 2 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… sdkauto/@azure-provisioning-webpubsub-7026014
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Qiaoqiao Zhang (qiaozha)
marked this pull request as ready for review
November 3, 2026 10:43
Qiaoqiao Zhang (qiaozha)
requested review from
a team,
Jialin Huang (JialinHuang803),
Mary Gao (MaryGao),
Rodge Fu (RodgeFu),
Jeremy Meng (jeremymeng) and
Qiaoqiao Zhang (qiaozha)
as code owners
November 3, 2026 10:43
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The package metadata contains incorrect repository and homepage paths, and the README misidentifies the provisioned service as Azure SignalR Service instead of Azure Web PubSub.
2 open issues
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Adds the first preview of @azure/provisioning-webpubsub to the Azure SDK monorepo. The package provides typed Web PubSub resources for authoring infrastructure definitions using @azure/provisioning-core, without modifying live Azure resources.
Changes:
- Adds nine resource classes covering Web PubSub services and child resources.
- Adds schema probes, documentation snippets, and Bicep/JSON rendering baselines.
- Integrates package builds, API reports, dependencies, and management CI.
Package-relative paths below are under sdk/web-pubsub/provisioning-webpubsub/; repository-level paths are shown in full.
| File | Description |
|---|---|
warp.config.yml |
Configures browser, ESM, and CommonJS builds. |
vitest.config.ts |
Uses shared Node test configuration. |
vitest.browser.config.ts |
References shared browser test configuration. |
tsp-location.yaml |
Records TypeSpec source and emitter metadata. |
tsconfig.json |
Connects source and test compilation projects. |
test/utils/index.ts |
Adds rendering and baseline comparison helpers. |
test/unit/schema-contract.source.ts |
Adds compile-time input contract probes. |
test/unit/public-entrypoints-web-pub-sub.test.baseline.json |
Records serialization for all resource classes. |
test/unit/public-entrypoints-web-pub-sub.test.baseline.bicep |
Records Bicep for all resource classes. |
test/unit/public-entrypoints-web-pub-sub.spec.ts |
Exercises resource construction through public exports. |
test/snippets.spec.ts |
Supplies the README authoring snippet. |
test/scenarios/swagger-examples/web-pub-sub-shared-private-link-resources-create-or-update.test.baseline.json |
Records replica-scoped link serialization. |
test/scenarios/swagger-examples/web-pub-sub-shared-private-link-resources-create-or-update.test.baseline.bicep |
Records replica-scoped link Bicep. |
test/scenarios/swagger-examples/web-pub-sub-shared-private-link-resources-create-or-update.swagger-request.json |
Supplies the shared-link request fixture. |
test/scenarios/swagger-examples/web-pub-sub-shared-private-link-resources-create-or-update.spec.ts |
Checks replica-scoped shared-link rendering. |
test/scenarios/swagger-examples/web-pub-sub-replica-shared-private-link-resources-create-or-update.test.baseline.json |
Records replica-parent serialization. |
test/scenarios/swagger-examples/web-pub-sub-replica-shared-private-link-resources-create-or-update.test.baseline.bicep |
Records replica-parent Bicep. |
test/scenarios/swagger-examples/web-pub-sub-replica-shared-private-link-resources-create-or-update.swagger-request.json |
Supplies an empty parent request projection. |
test/scenarios/swagger-examples/web-pub-sub-replica-shared-private-link-resources-create-or-update.spec.ts |
Checks the reduced replica-parent scenario. |
test/scenarios/swagger-examples/web-pub-sub-private-endpoint-connections-delete.test.baseline.json |
Records the named connection’s serialization. |
test/scenarios/swagger-examples/web-pub-sub-private-endpoint-connections-delete.test.baseline.bicep |
Records the named connection’s Bicep declaration. |
test/scenarios/swagger-examples/web-pub-sub-private-endpoint-connections-delete.swagger-request.json |
Supplies the bodyless example’s empty fixture. |
test/scenarios/swagger-examples/web-pub-sub-private-endpoint-connections-delete.spec.ts |
Renders a connection using DELETE-example naming. |
test/scenarios/swagger-examples/web-pub-sub-persistent-storages-create-or-update.test.baseline.json |
Records persistent-storage serialization. |
test/scenarios/swagger-examples/web-pub-sub-persistent-storages-create-or-update.test.baseline.bicep |
Records persistent-storage Bicep. |
test/scenarios/swagger-examples/web-pub-sub-persistent-storages-create-or-update.swagger-request.json |
Supplies the storage request fixture. |
test/scenarios/swagger-examples/web-pub-sub-persistent-storages-create-or-update.spec.ts |
Checks storage rendering against the request fixture. |
test/scenarios/swagger-examples/web-pub-sub-hubs-create-or-update.test.baseline.json |
Records hub settings serialization. |
test/scenarios/swagger-examples/web-pub-sub-hubs-create-or-update.test.baseline.bicep |
Records hub settings Bicep. |
test/scenarios/swagger-examples/web-pub-sub-hubs-create-or-update.swagger-request.json |
Supplies the hub request fixture. |
test/scenarios/swagger-examples/web-pub-sub-hubs-create-or-update.spec.ts |
Exercises event handlers, listeners, and chat settings. |
test/scenarios/swagger-examples/web-pub-sub-custom-domains-create-or-update.test.baseline.json |
Records custom-domain serialization. |
test/scenarios/swagger-examples/web-pub-sub-custom-domains-create-or-update.test.baseline.bicep |
Records custom-domain Bicep. |
test/scenarios/swagger-examples/web-pub-sub-custom-domains-create-or-update.swagger-request.json |
Supplies the custom-domain request fixture. |
test/scenarios/swagger-examples/web-pub-sub-custom-domains-create-or-update.spec.ts |
Checks domain and certificate-reference rendering. |
test/scenarios/swagger-examples/web-pub-sub-custom-certificates-create-or-update.test.baseline.json |
Records custom-certificate serialization. |
test/scenarios/swagger-examples/web-pub-sub-custom-certificates-create-or-update.test.baseline.bicep |
Records custom-certificate Bicep. |
test/scenarios/swagger-examples/web-pub-sub-custom-certificates-create-or-update.swagger-request.json |
Supplies the certificate request fixture. |
test/scenarios/swagger-examples/web-pub-sub-custom-certificates-create-or-update.spec.ts |
Checks Key Vault certificate settings rendering. |
test/scenarios/swagger-examples/web-pub-sub-create-or-update.test.baseline.json |
Records service configuration serialization. |
test/scenarios/swagger-examples/web-pub-sub-create-or-update.test.baseline.bicep |
Records service configuration Bicep. |
test/scenarios/swagger-examples/web-pub-sub-create-or-update.swagger-request.json |
Supplies the service request fixture. |
test/scenarios/swagger-examples/web-pub-sub-create-or-update.spec.ts |
Exercises identity, networking, tracing, and Socket.IO settings. |
test/scenarios/learning-site/webpubsub-sharedprivatelinkresources.test.baseline.json |
Records service-scoped shared-link serialization. |
test/scenarios/learning-site/webpubsub-sharedprivatelinkresources.test.baseline.bicep |
Records service-scoped shared-link Bicep. |
test/scenarios/learning-site/webpubsub-sharedprivatelinkresources.spec.ts |
Checks a service-scoped shared-link scenario. |
test/scenarios/learning-site/webpubsub-replicas.test.baseline.json |
Records replica settings serialization. |
test/scenarios/learning-site/webpubsub-replicas.test.baseline.bicep |
Records replica settings Bicep. |
test/scenarios/learning-site/webpubsub-replicas.spec.ts |
Exercises replica properties, SKU, and tags. |
test/scenarios/learning-site/webpubsub-replicas-sharedprivatelinkresources.test.baseline.json |
Records nested shared-link serialization. |
test/scenarios/learning-site/webpubsub-replicas-sharedprivatelinkresources.test.baseline.bicep |
Records nested shared-link Bicep. |
test/scenarios/learning-site/webpubsub-replicas-sharedprivatelinkresources.spec.ts |
Exercises replica links with FQDNs and approval messages. |
test/scenarios/learning-site/webpubsub-privateendpointconnections.test.baseline.json |
Records private-endpoint connection serialization. |
test/scenarios/learning-site/webpubsub-privateendpointconnections.test.baseline.bicep |
Records private-endpoint connection Bicep. |
test/scenarios/learning-site/webpubsub-privateendpointconnections.spec.ts |
Exercises endpoint references and connection approval settings. |
test/scenarios/learning-site/webpubsub-persistentstorages.test.baseline.json |
Records storage-reference serialization. |
test/scenarios/learning-site/webpubsub-persistentstorages.test.baseline.bicep |
Records storage-reference Bicep. |
test/scenarios/learning-site/webpubsub-persistentstorages.spec.ts |
Exercises persistent-storage authoring. |
test/scenarios/learning-site/webpubsub-hubs.test.baseline.json |
Records basic hub serialization. |
test/scenarios/learning-site/webpubsub-hubs.test.baseline.bicep |
Records basic hub Bicep. |
test/scenarios/learning-site/webpubsub-hubs.spec.ts |
Exercises hub connection policy and empty listeners. |
test/scenarios/learning-site/webpubsub-customdomains.test.baseline.json |
Records domain-reference serialization. |
test/scenarios/learning-site/webpubsub-customdomains.test.baseline.bicep |
Records domain-reference Bicep. |
test/scenarios/learning-site/webpubsub-customdomains.spec.ts |
Exercises custom-domain authoring. |
test/scenarios/learning-site/webpubsub-customcertificates.test.baseline.json |
Records certificate settings serialization. |
test/scenarios/learning-site/webpubsub-customcertificates.test.baseline.bicep |
Records certificate settings Bicep. |
test/scenarios/learning-site/webpubsub-customcertificates.spec.ts |
Exercises custom-certificate authoring. |
test/generated/public-entrypoints.spec.ts |
Checks that all nine resource classes are exported. |
src/web-pub-sub.ts |
Defines resource classes, properties, and serialization shapes. |
src/index.ts |
Exports resource classes and shared types. |
review/provisioning-webpubsub-types-browser.api.diff.md |
Records browser-specific type report differences. |
review/provisioning-webpubsub-browser.api.diff.md |
Records browser-specific package API differences. |
README.md |
Introduces infrastructure authoring and resource usage. |
package.json |
Defines package exports, dependencies, and scripts. |
LICENSE |
Adds the MIT license. |
eslint.config.mjs |
Configures package linting. |
config/tsconfig.test.node.json |
Configures Node tests and schema probes. |
config/tsconfig.test.browser.json |
Configures browser test type resolution. |
config/tsconfig.src.esm.json |
Configures ESM source compilation. |
config/tsconfig.src.cjs.json |
Configures CommonJS source compilation. |
config/tsconfig.src.browser.json |
Configures browser source compilation. |
config/tsconfig.lint.json |
Includes source and tests for lint analysis. |
CHANGELOG.md |
Introduces the first preview release. |
api-extractor.json |
Uses shared API extraction settings. |
sdk/web-pubsub/ci.mgmt.yml |
Adds package triggers and a CI artifact. |
pnpm-lock.yaml |
Registers the package’s dependency resolutions. |
eng/ignore-links.txt |
Exempts prerelease npm and API documentation links. |
Review effort: Balanced
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The shared-private-link scenarios construct incorrect resource types or use an empty request fixture, leaving the intended resource scopes and link properties unvalidated.
1 open issue
2 previously missed issues
In code that hasn't changed since last review
sdk/web-pubsub/provisioning-webpubsub/test/scenarios/swagger-examples/web-pub-sub-replica-shared-private-link-resources-create-or-update.spec.ts:62
This shared-private-link scenario constructs only a replica, and its {} request fixture makes the Swagger assertion pass without checking any link properties. Reference the replica as existing, create a WebPubSubReplicaSharedPrivateLink child from the source request, and update the asserted resource type, request fixture, and Bicep/JSON baselines together.
sdk/web-pubsub/provisioning-webpubsub/test/scenarios/swagger-examples/web-pub-sub-shared-private-link-resources-create-or-update.spec.ts:67
This service-scoped shared-private-link example constructs a replica-scoped link, so its baseline validates /webPubSub/replicas/sharedPrivateLinkResources instead of /webPubSub/sharedPrivateLinkResources. Sharing the request-body shape does not check the source operation's resource scope. Use WebPubSubSharedPrivateLink with service as its parent, remove the unused replica, and update the asserted resource type and both baselines.
1 resolved since last review
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The shared-private-link scenario tests only the parent replica with an empty fixture, leaving the intended resource and its properties unvalidated.
1 open issue
1 previously missed issue
In code that hasn't changed since last review
sdk/web-pubsub/provisioning-webpubsub/test/scenarios/swagger-examples/web-pub-sub-replica-shared-private-link-resources-create-or-update.spec.ts:62
This shared-private-link scenario constructs and selects only the parent Replica. With {} as the Swagger fixture, the request comparison passes for any rendered object without validating a shared private link or its properties. Reference an existing replica, construct WebPubSubReplicaSharedPrivateLink with the source request payload, and update the selected resource type, request fixture, and output baselines.
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
This comment has been minimized.
This comment has been minimized.
Updated README to reflect the new library name and its purpose. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Swagger example’s empty expected object validates no request properties, and its scenario constructs only the parent Replica instead of the shared-private-link resource.
1 open issue
1 resolved since last review
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
Contributor
Next Steps to Merge✅ All CI checks have passed. The PR is only marked "blocked" because it is awaiting required review/approval, so it is ready for review. The SDK engineer will review this PR shortly. Once it's approved, you can go ahead and merge it. To make things easier, feel free to enable auto-merge so it gets auto merged right after approval. For more details, see the management SDK release process. |
Qiaoqiao Zhang (qiaozha)
approved these changes
Nov 4, 2026
Qiaoqiao Zhang (qiaozha)
deleted the
sdkauto/@azure-provisioning-webpubsub-7026014
branch
November 4, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK generation details
Note
This pull request was generated automatically.
specification/webpubsub/resource-manager/Microsoft.SignalRService/SignalRService/tspconfig.yamlata75e2ceImportant
Complete the SDK release prerequisites before release.
fixes https://github.com/Azure/js-provisioning-lib/issues/514