Repository navigation
AB#3752409: Add platform broker telemetry tests and documentation - #8883
Merged
Lalima Sharda (lalimasharda) merged 9 commits intoOct 5, 2026
Merged
Conversation
Document nested platform broker telemetry and cover extension failure and broker cancellation signals. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0bced410-2a72-4ca0-ae17-b5eae8cb4d40
Add query dimensions and a correlation-based workflow for diagnosing provider selection, handshake outcomes, failures, cancellation, fallback, and latency. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0bced410-2a72-4ca0-ae17-b5eae8cb4d40
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 3
Open (4)
The table rows are prefixed with||, which renders as an extra empty column in many Markdown… · New This callback registration is not removed, which can leak into later tests and makeevents… · NewtoHaveBeenCalledWithrequires the first argument object to match exactly. If the implementation… · New IfcreateProviderEventisundefined,toMatchObjectwill fail but Jest will continue executing… · New
What changed in this PR
Updates platform broker performance documentation and adds focused test coverage to ensure telemetry correctly records extension discovery outcomes (unavailable/timeout) and broker user-cancellation.
Changes:
- Add a test asserting broker user cancellation maps to
BrowserAuthError/user_cancelledtelemetry. - Expand extension handler tests to validate timeout behavior emits only the root createProvider event context (and no standalone handshake event).
- Update performance documentation to describe nested extension-handshake telemetry fields and queryable outcome signals.
| File | Description |
|---|---|
| lib/msal-browser/test/interaction_client/PlatformAuthInteractionClient.spec.ts | Adds test coverage for broker user-cancellation telemetry mapping. |
| lib/msal-browser/test/broker/PlatformAuthExtensionHandler.spec.ts | Strengthens timeout test and asserts root-event context + no handshake event emission. |
| lib/msal-browser/docs/performance.md | Documents the nested platform broker telemetry model and recommended query dimensions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Lalima Sharda (lalimasharda)
October 2, 2026 21:45
View session
Co-authored-by: Forge <forge-bot@entra.github.io> Forge-Agent: Coder
Remove generated Forge status and prompt files that were committed by the failed PR comment loop. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0bced410-2a72-4ca0-ae17-b5eae8cb4d40
…tract (#8880) ## Summary Document the verified `navigator.platformAuthentication` compatibility contract, including capability and supported-contract checks, configuration gates, privacy considerations, and extension/web-flow fallback behavior. ## Implements - AB#3757762 — Document platformAuthentication browser compatibility contract ## How to validate - Confirm the documented flags and contract names match `PlatformAuthProvider.ts`, `PlatformAuthDOMHandler.ts`, and `BrowserConstants.ts`. - Confirm the relative link to `device-bound-tokens.md` resolves. <!-- BEGIN pr-telemetry --> assistance: agentic-cli type: docs agent-tool: copilot-cli agent-model: gpt-5.6-sol work-item: AB#3757762 <!-- END pr-telemetry --> --------- Copilot-Session: 0bced410-2a72-4ca0-ae17-b5eae8cb4d40
## Summary Clarifies that DPoP support in MSAL Browser is still in development, is not fully rolled out or production-ready, and should only be used for evaluation and testing. ## How to validate - Review the DPoP warnings in the access-token, request/response, response, and caching documentation. - Confirm the documentation no longer presents DPoP as generally available for production use. ## Notes Created by Forge `create-pr` skill. <!-- BEGIN pr-telemetry --> assistance: agentic-cli type: docs agent-tool: copilot-cli agent-model: gpt-5.6-sol work-item: AB#n/a <!-- END pr-telemetry --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1a77a9f7-1bca-4f21-8365-3c2c132f2c69
This PR contains the changelogs and version bumps for the MSAL.js 3P releases. --------- Co-authored-by: MSAL.js Release Automation <msaljsbuilds@microsoft.com> Co-authored-by: shylasummers <shylasummers@users.noreply.github.com> Co-authored-by: Shyla Summers <shylasummers@microsoft.com> Copilot-Session: 36ec2798-e86d-4fdd-8b64-72f3d40951d8
Clean up the timeout performance callback, fail clearly when the expected event is absent, and keep cancellation telemetry assertions resilient to additional fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0bced410-2a72-4ca0-ae17-b5eae8cb4d40
Update PR #8883 to the current dev head after addressing review feedback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0bced410-2a72-4ca0-ae17-b5eae8cb4d40
Thomas Norling (tnorling)
approved these changes
Oct 5, 2026
Thomas Norling (tnorling)
approved these changes
Oct 5, 2026
Hector Morales (hectormmg)
approved these changes
Oct 5, 2026
Lalima Sharda (lalimasharda)
deleted the
js-wam/platform-broker-telemetry-gaps
branch
October 5, 2026 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Correct the platform broker performance documentation to describe the final nested extension-handshake telemetry model and its queryable outcome signals.
Add focused telemetry coverage for an unavailable extension, an extension handshake timeout, and user cancellation returned by the platform broker.
Implements
How to validate
PlatformAuthExtensionHandlerandPlatformAuthInteractionClienttests.BrowserAuthError/user_cancelled.Validation
assistance: agentic-cli
type: telemetry
agent-tool: copilot-cli
agent-model: gpt-5.6-sol
work-item: AB#3752409