Repository navigation
fix(network): enforce one active link and persist ethernet-off intent - #310
Merged
gmmcosta15 merged 7 commits intoSep 28, 2026
Merged
gmmcosta15 merged 7 commits into
gmmcosta15 merged 7 commits into
Conversation
3 tasks done
…/boot/VLAN, keep saved profile on failed add
…le-link-exclusivity
…le-link-exclusivity
# Description - [x] Code refactor Stacked on #2, review after it merges. Behaviour-neutral motion only, extracts helpers to cut cyclomatic complexity below the C901 threshold (10). Reviewable as pure motion. - Extract `_gather_ap_properties`, `_gather_settings`, `_vlan_*`, `_prefix_to_mask`, `_parse_ipv4_settings`, `_unwrap`, `_setting`, `_delete_connections_where`, `_delete_all_connections_by_id`, `_find_ap_props`, `_reload_connections` - `models.py` cleanup # Tests All 5 gates pass standing alone, including `ruff check --select C901` over the network layer. No behaviour change (pure extraction).
An error occurred while trying to automatically change base from
refactor/network-extract-helpers
to
dev
September 28, 2026 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #3, review after it merges.
Highest review value in the stack, this is where the field bugs were. Enforces exactly one of Wi-Fi/ethernet/hotspot active at a time, on user toggles only. Background/automatic state handlers never drop a link behind the user's back.
_set_wired_profiles_autoconnect,_ensure_wired_autoconnectmanager.py/worker.pynetworkWindow.pytoggle handlers + loading guard armed before link changesTests
All 5 gates pass standing alone.