fix(notifications): clean up NotificationPage and keep the info panel in sync with selection - #334
Open
gmmcosta15 wants to merge 7 commits into
Open
Conversation
…ewest first, add icon-text spacing
… padding universal
…ick, dedupe refresh, delete/reset), add universal icon-text padding
gmmcosta15
added this pull request to stack #335
September 9, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
Cleans up
NotificationPageand fixes several cases where the info panel (Type/Time) fell out of sync with what's actually selected in the list.update_*widget/method names tonotification_*.on_update_messagesignal and unusedcli_trackingdeque.EntryDelegate.prev_indexdrift: since new notifications now prepend instead of append, every existing row shifts down on insert,prev_index(used to know which row's highlight to clear) is now kept valid via arowsInsertedhandler.item_selected.refresh_last_if_duplicate): the cached timestamp bumped correctly, but if that item was currently shown in the info panel, its Time label stayed frozen at the first occurrence. It's now refreshed too.EntryListModel.setData(ExpandRole)never returningTrue, violating Qt'ssetDatacontract.Motivation
NotificationPagestill carried dead code and naming from when it was the Update page. While reordering to newest-first, several latent bugs in the shared list delegate's click/selection handling surfaced (or became user-visible for the first time, since the newest/topmost item is now the first thing a user sees and clicks).Tests
tests/util/test_notification_page_unit.pyupdated for the renamed widgets, all 4 tests pass.